revert(sdk-coin-hbar): remove buildTransferData merge logic from PR #8774#8795
Merged
Merged
Conversation
…8774 The merge logic in coinTransferBuilder.ts was collapsing transfer entries with the same accountID, which broke normal HBAR transfers where sender and recipient share the same base address (memo-based addresses like 0.0.X?memoId=Y). The merge was unnecessary for claim rewards since that flow uses a different builder path. The self-transfer fallback in transaction.ts getTransferData() (from PR #8742) already handles claim rewards correctly with isPositive() for the 1-tinybar self-transfer. This reverts merge commit c0b28ee. Ticket: SI-605
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coinTransferBuilder.tsintroduced by PR fix(sdk-coin-hbar): merge same-account entries in buildTransferData to fix ACCOUNT_REPEATED #8774 (commitc27392747f)0.0.X?memoId=Y)transaction.tsgetTransferData()(from PR test(hbar): add unit tests for CoinTransferBuilder self-transfer #8742) already handles claim rewards correctlyRoot Cause
buildHederaAccountID()strips memo from addresses, so0.0.Aand0.0.A?memoId=1produce the same proto AccountID key. The merge collapsed[{acct, -N}, {acct, +N}]into[{acct, 0}], causingverifyTransaction()to fail with "Tx outputs does not match with expected txParams recipients" because parsed amount"0"!= expected amount"N".Test plan
getTransferData()handles 1-tinybar positive entry)Ticket: SI-605