Skip to content

revert(sdk-coin-hbar): remove self-transfer fallback from PR #8742 #8798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Doddanna17 merged 1 commit into from
May 19, 2026
+0 −123
Merged

revert(sdk-coin-hbar): remove self-transfer fallback from PR #8742 #8798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions modules/sdk-coin-hbar/src/lib/transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,21 +153,6 @@ export class Transaction extends BaseTransaction {
}
});

// Handle self-transfer: when sender == recipient, the positive entry is filtered out above
// because its accountID matches the sender. Fall back to including it as the recipient.
if (transferData.length === 0 && transfers.length > 0) {
const selfTransferEntry = transfers.find((t) => Long.fromValue(t.amount!).isPositive());
if (selfTransferEntry) {
transferData.push({
address: stringifyAccountId(selfTransferEntry.accountID!),
amount: Long.fromValue(selfTransferEntry.amount!).toString(),
...(tokenTransfers.length && {
tokenName: tokenName,
}),
});
}
}

return {
...(tokenTransfers.length && {
tokenName: tokenName,
Expand Down
108 changes: 0 additions & 108 deletions modules/sdk-coin-hbar/test/unit/transactionBuilder/coinTransferBuilder.ts
View file
Open in desktop

This file was deleted.

Loading