Conversation
There was a problem hiding this comment.
Pull request overview
Adds support in the Canton SDK for an “AllocationRequest” txRequest (an internal/dummy transaction type) to surface DvP trade/leg details to an allocating party, including a new builder and transaction serialization support.
Changes:
- Adds
TransactionType.AllocationRequestto sdk-core and wires it into Canton’sTransactionBuilderFactory. - Introduces
AllocationRequestBuilderplus a newAllocationRequestinterface for representing the surfaced trade leg details. - Extends Canton
Transactionencode/decode/broadcast-json handling to supportallocationRequestDatapayloads, and adds unit tests for the new builder.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/sdk-core/src/account-lib/baseCoin/enum.ts | Adds new TransactionType.AllocationRequest. |
| modules/sdk-coin-canton/src/lib/allocationRequestBuilder.ts | New builder to construct/validate AllocationRequest objects. |
| modules/sdk-coin-canton/src/lib/iface.ts | Adds AllocationRequest interface and threads it through broadcast/json shapes. |
| modules/sdk-coin-canton/src/lib/index.ts | Exports AllocationRequestBuilder. |
| modules/sdk-coin-canton/src/lib/transactionBuilderFactory.ts | Adds factory routing for TransactionType.AllocationRequest. |
| modules/sdk-coin-canton/src/lib/transaction/transaction.ts | Adds storage + (de)serialization logic for allocationRequestData; treats it as dummy-signable payload. |
| modules/sdk-coin-canton/test/unit/builder/allocationRequest/allocationRequestBuilder.ts | New unit tests for the builder. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ticket: CHALO-479
hrishikeshjain
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CHALO-479