CSHLD-886: Fix incorrect hashbytes padding in sBTC withdraw builder#8830
Merged
Conversation
The withdraw builder was zero-padding all BTC address hash bytes to 32 bytes. P2PKH, P2SH, and P2WPKH addresses have 20-byte hashes and should not be padded. Pass decoded hash bytes directly and add test assertions to verify correct buffer lengths per address type. Ticket: CSHLD-886
mukeshsp
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove incorrect 32-byte zero-padding of BTC address hash bytes in the sBTC withdraw builder. P2PKH, P2SH, and P2WPKH addresses have 20-byte hashes and were being incorrectly padded to 32 bytes.
Linear: CSHLD-886
Changes
HASHBYTES_BUFFER_LENGTHconstant and 32-byte zero-padding logic fromwithdrawParamsToFunctionArgsinsbtcWithdrawBuilder.tsdecoded.hashBytesdirectly tobufferCVinstead of paddingTest Plan