Skip to content

feat(sdk-core): add externalSigner createOfflineRound1Share handler#8833

Merged
vibhavgo merged 1 commit into
masterfrom
WCI-378
May 25, 2026
Merged

feat(sdk-core): add externalSigner createOfflineRound1Share handler#8833
vibhavgo merged 1 commit into
masterfrom
WCI-378

Conversation

@vibhavgo
Copy link
Copy Markdown
Contributor

Add the EdDSA MPCv2 offline round-1 handler for external signer flows. It stores encrypted carry-over state for the next signing round.

  • Generate the round-1 EdDSA MPCv2 signature share from a fresh DSG session.
  • Persist DSG session state and user message payload in the round-1 session.
  • Encrypt session and ephemeral GPG private key data with signing-context adata.
  • Cover SJCL encryption, v2 envelopes, payload shape, and transaction guards.

Ticket: WCI-378

Add the EdDSA MPCv2 offline round-1 handler for external signer flows.
It stores encrypted carry-over state for the next signing round.

- Generate the round-1 EdDSA MPCv2 signature share from a fresh DSG session.
- Persist DSG session state and user message payload in the round-1 session.
- Encrypt session and ephemeral GPG private key data with signing-context adata.
- Cover SJCL encryption, v2 envelopes, payload shape, and transaction guards.

Ticket: WCI-378
@vibhavgo vibhavgo requested review from a team as code owners May 22, 2026 07:39
@vibhavgo vibhavgo requested review from bdesoky and lokesh-bitgo May 22, 2026 07:39
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 22, 2026

WCI-378

@vibhavgo vibhavgo requested a review from Marzooqa May 22, 2026 08:34
Copy link
Copy Markdown
Contributor

@Marzooqa Marzooqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation matches the WCI-378 spec exactly and follows the ECDSA pattern faithfully. No bugs found. Two minor suggestions inline.

Comment thread modules/sdk-core/test/unit/bitgo/utils/tss/eddsa/eddsaMPCv2.ts
Comment thread modules/sdk-core/test/unit/bitgo/utils/tss/eddsa/eddsaMPCv2.ts
@vibhavgo vibhavgo merged commit 9e96014 into master May 25, 2026
26 checks passed
@vibhavgo vibhavgo deleted the WCI-378 branch May 25, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants