CSHLD-906: Add bridgingParams support for BTC-to-sBTC bridging transactions#8850
Merged
Merged
Conversation
abhi-bitgo
force-pushed
the
CSHLD-906-add-btc-sbtc-bridging-params
branch
2 times, most recently
from
d75aa64 to
7cc82ac
Compare
mukeshsp
previously approved these changes
May 28, 2026
Contributor
pritam-gembali
left a comment
pritam-gembali
left a comment
There was a problem hiding this comment.
Nice, small, additive change. Posted inline comments on a couple of follow-ups worth addressing before merge — primarily an assert so a bridging request without bridgingParams fails loudly instead of silently no-op'ing, and a codec-level decode test for BridgingParamsCodec so the Express contract is enforced by tests, not just types.
The broader design (namespaced BridgingParams.sbtc) is good — leaves room for future bridge targets without breaking changes. Risk is low since no existing intent paths change behavior.
Add bridgingParams to the BTC transaction build pipeline for cross-chain BTC-to-sBTC bridging. The parameter flows through all wallet types: non-TSS (hot/cold via BuildParams whitelist), TSS (via new 'bridging' case in prebuild switch), and custodial. Shared types (SbtcBridgingParams, BridgingParams) defined once in iWallet.ts and reused across sdk-core and express typed routes. bridgingParams is conditionally included in populateIntent only for intentType === 'bridging'. Ticket: CSHLD-906
veetragjain
force-pushed
the
CSHLD-906-add-btc-sbtc-bridging-params
branch
from
7cc82ac to
0f27d93
Compare
pritam-gembali
approved these changes
May 28, 2026
mukeshsp
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
bridgingParamsto the BTC transaction build pipeline to support BTC-to-sBTC cross-chain bridging. The parameter flows through all wallet types (hot, cold, custodial, TSS).Linear: CSHLD-906
Changes
SbtcBridgingParamsandBridgingParamsinterfaces iniWallet.tsbridgingParamstoPrebuildTransactionOptionsfor SDK callersbridgingParamsinBuildParams.tsfor non-TSS/tx/buildpath`BridgingParamsCodecio-ts codec insendmany.ts, reused inprebuildAndSignTransaction.ts/tx/buildTest Plan
BuildParamscodec whitelist (bridgingParams passes, unknown fields stripped)bridgingParamsreaches/tx/buildendpoint