feat(wasm-utxo): improve code quality with idiomatic Rust patterns #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export all public items from the address module instead of just the utxolib_compat namespace. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
Replace boolean equality comparisons with direct assertions and other idiomatic patterns throughout the codebase. Improve function parameter handling by removing unnecessary references and dereferences. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
Use enumerate() with iterator in cashaddr polymod calculation for improved readability. This eliminates manual indexing while maintaining the same functionality. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
Improves code clarity by replacing the manual match statement with the more concise matches! macro for descriptor type checking. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
Improve code quality by implementing the Display trait for WrapDescriptor and refactoring the to_string method to use it, following best practices. Added an allow annotation for clippy warning about shadowing Display trait. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
Adds proper Display trait implementation for WrapMiniscript and refactors toString to use it instead of directly calling the inner implementation. Adds necessary clippy allow attribute to handle shadow warning. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
Remove unnecessary blank line in cashaddr module's test section and refactor multisig script parsing to use iterator methods instead of index-based loops for better readability and safer iteration. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
Implemented Clone trait for WrapPsbt to provide proper cloning functionality and addressed clippy lint warnings about manually implementing the trait method. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
OttoAllmendinger
force-pushed
the
BTC-2652.add-fixedscriptwallet-outputs.lint-fix
branch
from
0f1c070 to
6d5051c
Compare
ppongbitgo
approved these changes
Oct 27, 2025
OttoAllmendinger
deleted the
BTC-2652.add-fixedscriptwallet-outputs.lint-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
cargo clippyhappyBTC-2652