feat(wasm-utxo): implement MuSig2 with BitGo-specific p2tr variant #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
Added serde, serde_json, and hex crates to dev-dependencies to enhance test capabilities in the wasm-utxo package. Co-authored-by: llm-git <llm-git@ttll.de> Issue: BTC-2652
Re-export bitcoin from miniscript to support transition to a more general bitcoin package. This provides easier access to the bitcoin module. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
OttoAllmendinger
force-pushed
the
BTC-2652.add-bitgo-musig2
branch
from
eb1bfa5 to
4f8dbde
Compare
Add the BIP-327 reference implementation for MuSig2 multi-signature protocol including Python code and test vectors. Issue: BTC-2652 1: https://github.com/bitcoin/bips/blob/ab9d5b8/bip-0327/reference.py Co-authored-by: llm-git <llm-git@ttll.de>
This adds a modified version of BIP-0327 reference implementation to support BitGo's legacy p2tr aggregation method. The implementation adds: 1. Support for x-only pubkeys in key aggregation 2. Legacy p2tr aggregation function that converts to x-only format before sorting 3. Enhanced sign and verify functions to handle both pubkey formats 4. Comprehensive test cases to verify both standard MuSig2 (p2trMusig2) and legacy p2tr behavior Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
Add implementation of BitGo's non-standard variant of MuSig2 key aggregation that uses x-only (32-byte) pubkeys in the hash computation. This differs from the standard BIP327 implementation and is required for compatibility with existing BitGo wallets. BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
OttoAllmendinger
force-pushed
the
BTC-2652.add-bitgo-musig2
branch
from
4f8dbde to
663d0d9
Compare
ppongbitgo
previously approved these changes
Oct 22, 2025
To satisfy the config of the `infra/` repo mostly. It's not a great name. Co-authored-by: llm-git <llm-git@ttll.de>
OttoAllmendinger
force-pushed
the
BTC-2652.add-bitgo-musig2
branch
from
c79e8b3 to
1abb959
Compare
lcovar
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds part of the MuSig2 multi-signature protocol implementation with support
for BitGo's legacy p2tr aggregation method.
This enables the generation of the legacy
p2trandp2trMusig2script types in subsequent steps.The implementation includes:
Additional improvements:
Note that this does not include any signing code yet.
Issue: BTC-2652