fix!: bump BitGo SDK and fix UTXO multisig sendMany#192
Merged
mohammadalfaiyazbitgo merged 1 commit intomasterfrom Apr 23, 2026
Merged
fix!: bump BitGo SDK and fix UTXO multisig sendMany#192mohammadalfaiyazbitgo merged 1 commit intomasterfrom
mohammadalfaiyazbitgo merged 1 commit intomasterfrom
Conversation
pranishnepal
commented
Apr 22, 2026
pranishnepal
commented
Apr 22, 2026
| "zod": "^3.25.48" | ||
| }, | ||
| "overrides": { | ||
| "@bitgo-beta/sdk-core": "8.2.1-beta.1231", |
Contributor
Author
There was a problem hiding this comment.
pranishnepal
commented
Apr 22, 2026
pranishnepal
commented
Apr 23, 2026
| baseCoin.keychains().get({ id: wallet.keyIds()[KeyIndices.BACKUP] }), | ||
| baseCoin.keychains().get({ id: wallet.keyIds()[KeyIndices.BITGO] }), | ||
| ]); | ||
| const walletPubs = |
Contributor
Author
There was a problem hiding this comment.
The new BitGo JS version requires 3 keys for UTXO: https://github.com/BitGo/BitGoJS/blob/304f5dd1211042857575e2195faae1dac8e91ee8/modules/abstract-utxo/src/transaction/fixedScript/signTransaction.ts#L108-L110, starting BitGo/BitGoJS#7703
Contributor
Author
There was a problem hiding this comment.
{
"error": "Internal Server Error",
"name": "AssertionError",
"details": "pubs are required for fixed script signing"
}
Contributor
mohammadalfaiyazbitgo
left a comment
mohammadalfaiyazbitgo
left a comment
There was a problem hiding this comment.
can you mark this as a breaking change?
pranishnepal
changed the title
BREAKING CHANGE: abstract-utxo@1941 added assert(params.pubs) in the BitGoPsbt signing path. sendMany for UTXO wallets now fetches all 3 keychains and passes walletPubs=[userPub,backupPub,bitgoPub] through the signing stack to satisfy this assertion. - Bump all @bitgo-beta packages to latest - Fix UTXO recovery test: replace legacy txHex fixture with valid PSBT - Fix sendMany for UTXO coins: wire walletPubs through handleSendMany to signAndSendMultisig to advancedWalletManagerClient to signMultisigTransaction - Add tests covering walletPubs behaviour and BitGoPsbt signing path Ticket: WAL-762
Contributor
Author
Great point, this started with a simple bump and led to a breaking change. Done! |
mohammadalfaiyazbitgo
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This commit updates the version of the bitgo SDK to the latest.
Ticket: WAL-762
Breaking Change
BREAKING CHANGE:
abstract-utxo@1941added assert(params.pubs) in theBitGoPsbtsigning path.sendManyfor UTXO wallets now fetches all 3 keychains and passeswalletPubs=[userPub,backupPub,bitgoPub]through the signing stack to satisfy this assertion.Testing