Structural superagent dependency #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitgopatmcl
commented
Jun 23, 2022
bitgopatmcl
force-pushed
the
structural-superagent-dependency
branch
from
53054d5 to
0023526
Compare
ericcrosson-bitgo
approved these changes
Jun 23, 2022
ryan-bitgo
approved these changes
Jun 23, 2022
|
🎉 This PR is included in version 1.0.0-beta.14 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.2.0-beta.9 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
| query(params: Record<string, string | string[]>): this; | ||
| set(name: string, value: string): this; | ||
| send(body: string): this; | ||
| } |
There was a problem hiding this comment.
Does this implementation mean we won't learn if superagent changes out from underneath us?
|
🎉 This PR is included in version 0.2.0-beta.7 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.2.0-beta.4 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@api-ts/superagent-wrapperonly actually uses a small subset of superagent's functionality. This PR adds the necessary type declarations so that it can be compatible with the widest possible range of superagent versions.