Skip to content

fix: add default param to requestHandler impl #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2022
Merged

fix: add default param to requestHandler impl #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/express-wrapper/src/request.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,12 @@ export function routeHandler<R extends HttpRoute, Chain extends MiddlewareChain>
}): RouteHandler<R>;

export function routeHandler<R extends HttpRoute>({
middleware,
middleware = [],
handler,
}: any): RouteHandler<R> {
}: {
middleware?: express.RequestHandler[];
handler: ServiceFunction<R, any>;
}): RouteHandler<R> {
// This function wouldn't be needed if TS had value/object level existential quantification, but since it doesn't we enforce the relationship
// between the middleware chain and the handler's input params with this function and then assert the result.
return { middleware, handler, [MiddlewareBrand]: true } as RouteHandler<R>;
Expand Down