fix: attempt to handle response types more cleanly #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redefines a "service function" so that the return type is either all numeric or all keyed. This is a bit of a guess, but the hope is that it resolves some of the weird typechecking issues we are seeing around response types.
bitgopatmcl
force-pushed
the
express-response-type-experiment
branch
from
63374a2 to
7143029
Compare
jonball4
approved these changes
Aug 4, 2022
Contributor
|
Works well using solely |
ericcrosson-bitgo
approved these changes
Aug 4, 2022
|
🎉 This PR is included in version 0.2.0-beta.8 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0-beta.21 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.2.0-beta.10 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.2.0-beta.14 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redefines a "service function" so that the return type is either all
numeric or all keyed. This is a bit of a guess, but the hope is that it
resolves some of the weird typechecking issues we are seeing around
response types.