-
Notifications
You must be signed in to change notification settings - Fork 22
feat: add typed-express-router package #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
14a21dc to
0bcbf80
Compare
0bcbf80 to
ccc8437
Compare
ericcrosson-bitgo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main file index.ts file looks pretty simple, true to the idea of this new package. Thanks for the high test coverage! Plenty of examples of use made it easy to review this code
Looks great to me, I won't merge after approval in case you wanted to manually add a git tag that semantic-release will pick up as an input in calculating the next package version. I think if we don't add a tag it'll pick some beta form of 1.0.0 (but on the beta dist tag, FAQ). I have no idea what happens when we drop out of beta in that case, whether we land on v1 or v2
ccc8437 to
e1e58ad
Compare
|
🎉 This PR is included in version 1.0.0-beta.22 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.2.0-beta.9 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.2.0-beta.11 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.2.0-beta.15 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Initial PR for a lighter weight integration of api-ts specifications with Express. The idea is to provide a relatively unopinionated base layer that provides type-checked requests and is flexible enough for other packages to build off of. This should improve familiarity and DX while simultaneously not reinventing the wheel on much of the functionality the existing router provides.
Goals
apiSpecencodefunctionhttpRoute(e.g. for aliases)Non-Goals
apiSpechave an associated route handlerexpress.RequestHandler[]chain beyond the additionalproperties described above (projects and other libraries can do this)