Skip to content

Conversation

@bitgopatmcl
Copy link
Contributor

Quick iteration on the typed-express-router api based on implementation feedback.
Changes:

  • Alias methods removed and changed to an option.
  • Unchecked method behavior changed, they still attempt to decode a request but just put the resulting Either on the request.
  • Router-level middleware (router.use(middleware)) can inspect the same Either decoded requests, even on checked routes before it is validated and unwrapped.

@bitgopatmcl bitgopatmcl requested a review from a team as a code owner August 11, 2022 21:22
Copy link
Contributor

@ericcrosson-bitgo ericcrosson-bitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this implementation of aliases. You turned this into a good outcome @bitgopatmcl, breaking through a local maximum with a new way of thinking, and taking it from concept to a far superior solution in a flash. Great work!

@ericcrosson-bitgo ericcrosson-bitgo merged commit 6e4f9f9 into BitGo:beta Aug 11, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-beta.24 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.2.0-beta.1 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.2.0-beta.9 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.2.0-beta.11 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.2.0-beta.15 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

🎉 This PR is included in version 0.2.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants