Skip to content

Conversation

@bitgopatmcl
Copy link
Contributor

No description provided.

@bitgopatmcl bitgopatmcl requested a review from a team April 5, 2022 13:06
README.md Outdated
A collection of packages for defining and using type-checked apis with TypeScript.

TypeScript is a very powerful type system layered on top of JavaScript, but one drawback
it has is that this extra type information is not available at runtime.
Copy link
Contributor

@ericcrosson-bitgo ericcrosson-bitgo Apr 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth talking about how this constraint is not expected to change?

Non-goals
...
Add or rely on run-time type information in programs, or emit different code based on the results of the type system.

https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals#non-goals

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

README.md Outdated
TypeScript is a very powerful type system layered on top of JavaScript, but one drawback
it has is that this extra type information is not available at runtime.
[io-ts](https://github.com/gcanti/io-ts) fills in this functionality gap.
`io-ts-http`(packages/io-ts-http/README.md) builds on top of `io-ts` to make it possible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`io-ts-http`(packages/io-ts-http/README.md) builds on top of `io-ts` to make it possible
[`io-ts-http`](packages/io-ts-http/README.md) builds on top of `io-ts` to make it possible

Seems helpful to provide a hyperlink here

Copy link
Contributor

@ericcrosson-bitgo ericcrosson-bitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it!

One general principle I think we can improve on is "use fewer words". That was my big take-away from working with Gwen to improve my technical writing.

For example, instead of

TypeScript is a very powerful type system layered on top of JavaScript, but one drawback it has is that this extra type information is not available at runtime

we could write

TypeScript is a very powerful type system layered on top of JavaScript, but lacks type information available at runtime

replacing 8 words with 1!

I feel we could even improve the first part of this sentence (before the comma), but iteration is the name of the game.

Thanks for putting this documentation out! 🚀

Copy link
Contributor

@ericcrosson-bitgo ericcrosson-bitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕺 noice!

@ericcrosson-bitgo ericcrosson-bitgo merged commit ff78c84 into BitGo:master Apr 5, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.2.0-beta.1 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.1.1-beta.1 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.2.0-beta.1 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants