fix!: rename errors to error in 400 responses #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency, since the value of this key is a scalar (`string`) and not a vector, and for congruence with our convention at BitGo of handling errors. Closes BitGo#39 BREAKING CHANGE: rename `errors` to `error` in 400 response
ericcrosson-bitgo
force-pushed
the
39-rename-errors-to-error-for-consistency
branch
from
054a2ed to
cb76bc4
Compare
oof! We hit a timeout-related flake in this CI run[^1] ``` @api-ts/openapi-generator:test: @api-ts/openapi-generator:test: ✖ Timed out while running tests @api-ts/openapi-generator:test: @api-ts/openapi-generator:test: 14 tests were pending in test/test-corpus.ts @api-ts/openapi-generator:test: @api-ts/openapi-generator:test: ◌ should parse array types @api-ts/openapi-generator:test: ◌ should parse boolean literals @api-ts/openapi-generator:test: ◌ should parse discriminated unions @api-ts/openapi-generator:test: ◌ should simplify intersections of plain types @api-ts/openapi-generator:test: ◌ should handle multiple routes at different paths @api-ts/openapi-generator:test: ◌ should parse unions of multiple types @api-ts/openapi-generator:test: ◌ should parse explicit nulls @api-ts/openapi-generator:test: ◌ should read optional properties @api-ts/openapi-generator:test: ◌ should parse record types @api-ts/openapi-generator:test: ◌ should handle multiple routes at one path @api-ts/openapi-generator:test: ◌ should create an OpenAPI spec @api-ts/openapi-generator:test: ◌ should parse string unions @api-ts/openapi-generator:test: ◌ should handle unknown properties in responses @api-ts/openapi-generator:test: ◌ should parse version tags @api-ts/openapi-generator:test: @api-ts/openapi-generator:test: ─ @api-ts/openapi-generator:test: @api-ts/openapi-generator:test: npm ERR! Lifecycle script `test` failed with error: @api-ts/openapi-generator:test: npm ERR! Error: command failed @api-ts/openapi-generator:test: npm ERR! in workspace: @api-ts/openapi-generator@0.1.0 @api-ts/openapi-generator:test: npm ERR! at location: /home/runner/work/api-ts/api-ts/packages/openapi-generator @api-ts/openapi-generator:test: Error: command finished with error: command (packages/openapi-generator) npm run test exited (1) ``` Tests thankfully don't take close to 30 seconds locally (though they are slow -- around 10s) but in parallel CI with shared compute resources, anything goes. This commit bumps the test timeout from 30 seconds to 1 minute to avoid flakes of this sort in the future. [^1]: https://github.com/BitGo/api-ts/runs/5980525873?check_suite_focus=true
| } | ||
| }, | ||
| "timeout": "30s" | ||
| "timeout": "1m" |
Contributor
Author
There was a problem hiding this comment.
Relevant documentation: https://github.com/avajs/ava/blob/main/docs/07-test-timeouts.md
bitgopatmcl
approved these changes
Apr 11, 2022
|
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.2.0-beta.1 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.1.1-beta.1 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.2.0-beta.1 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency, since the value of this key is a scalar (
string)and not a vector, and for congruence with our convention at BitGo of
handling errors.
Closes #39