Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Feb 16, 2023

This PR fixes the following npm vulnerability:

http-cache-semantics  <4.1.1
Severity: high
http-cache-semantics vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-rc47-6667-2j5j
fix available via `npm audit fix`
node_modules/npm/node_modules/http-cache-semantics

@ghost ghost self-requested a review as a code owner February 16, 2023 18:50
@socket-security
Copy link

Socket Security Pull Request Report

Dependency issues detected: If you merge this pull request, you will not be alerted to the instances of these issues again.

😵‍💫 Bin script confusion

This package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack

Consider removing one of the conflicting packages. Packages should only export bin scripts with their name

Package Bin script Source
npm@8.19.4 (upgraded) rimraf package-lock.json via @semantic-release-extras/github-comment-specific@1.0.5, multi-semantic-release@3.0.1
rimraf@3.0.2 (added) rimraf package-lock.json via @semantic-release-extras/github-comment-specific@1.0.5, multi-semantic-release@3.0.1, packages/express-wrapper/package.json via ava@5.2.0, c8@7.12.0, packages/io-ts-http/package.json via c8@7.12.0, packages/openapi-generator/package.json via ava@5.2.0, c8@7.12.0, packages/superagent-wrapper/package.json via c8@7.12.0, packages/typed-express-router/package.json via ava@5.2.0, c8@7.12.0, website/package-lock.json via @docusaurus/core@2.0.0-rc.1, @docusaurus/preset-classic@2.0.0-rc.1
npm@8.19.4 (upgraded) semver package-lock.json via @semantic-release-extras/github-comment-specific@1.0.5, multi-semantic-release@3.0.1
semver@5.7.1 (added) semver package-lock.json via @semantic-release-extras/github-comment-specific@1.0.5, multi-semantic-release@3.0.1, website/package-lock.json via @docusaurus/core@2.0.0-rc.1, @docusaurus/preset-classic@2.0.0-rc.1
semver@6.3.0 (added) semver package-lock.json via @semantic-release-extras/github-comment-specific@1.0.5, multi-semantic-release@3.0.1, packages/express-wrapper/package.json via c8@7.12.0, packages/io-ts-http/package.json via c8@7.12.0, packages/openapi-generator/package.json via c8@7.12.0, packages/superagent-wrapper/package.json via c8@7.12.0, packages/typed-express-router/package.json via c8@7.12.0, website/package-lock.json via @docusaurus/core@2.0.0-rc.1, @docusaurus/preset-classic@2.0.0-rc.1, docusaurus-theme-mdx-v2@0.1.2
semver@7.3.8 (added) semver package-lock.json via @semantic-release-extras/github-comment-specific@1.0.5, multi-semantic-release@3.0.1, packages/express-wrapper/package.json via ava@5.2.0, packages/openapi-generator/package.json via ava@5.2.0, packages/superagent-wrapper/package.json via superagent@8.0.9, supertest@6.3.3, packages/typed-express-router/package.json via ava@5.2.0
npm@8.19.4 (upgraded) node-which package-lock.json via @semantic-release-extras/github-comment-specific@1.0.5, multi-semantic-release@3.0.1
which@2.0.2 (added) node-which package-lock.json via @semantic-release-extras/github-comment-specific@1.0.5, lint-staged@13.1.2, multi-semantic-release@3.0.1, packages/express-wrapper/package.json via @ava/typescript@3.0.1, ava@5.2.0, c8@7.12.0, packages/io-ts-http/package.json via c8@7.12.0, packages/openapi-generator/package.json via @ava/typescript@3.0.1, ava@5.2.0, c8@7.12.0, packages/superagent-wrapper/package.json via c8@7.12.0, packages/typed-express-router/package.json via @ava/typescript@3.0.1, ava@5.2.0, c8@7.12.0, website/package-lock.json via @docusaurus/core@2.0.0-rc.1, @docusaurus/preset-classic@2.0.0-rc.1
npm@8.19.4 (upgraded) mkdirp package-lock.json via @semantic-release-extras/github-comment-specific@1.0.5, multi-semantic-release@3.0.1
Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ⚠️ 9 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

  • @SocketSecurity ignore npm@8.19.4
  • @SocketSecurity ignore rimraf@3.0.2
  • @SocketSecurity ignore semver@5.7.1
  • @SocketSecurity ignore semver@6.3.0
  • @SocketSecurity ignore semver@7.3.8

Powered by socket.dev

Copy link
Contributor

@ericcrosson-bitgo ericcrosson-bitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumps npm in a lockfile

This project is not exposed to the http-cache-semantics vulnerability since it is not a server, but silencing alerts is helpful nonetheless.

Thanks @louib-bitgo!

@ericcrosson-bitgo ericcrosson-bitgo merged commit 6d068bc into master Feb 16, 2023
@ericcrosson-bitgo ericcrosson-bitgo deleted the fix_npm_vulnerability branch February 16, 2023 19:27
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

🎉 This PR is included in version @api-ts/response@2.1.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

🎉 This PR is included in version @api-ts/express-wrapper@1.0.15 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

🎉 This PR is included in version @api-ts/io-ts-http@2.2.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

🎉 This PR is included in version @api-ts/openapi-generator@1.0.7 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

🎉 This PR is included in version @api-ts/superagent-wrapper@1.1.9 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

🎉 This PR is included in version @api-ts/typed-express-router@1.0.12 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants