Skip to content

test: replace ava with node:test #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2023
Merged

test: replace ava with node:test #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13d437a
build(nix): upgrade nixpkgs flake input
ericcrosson-bitgo May 27, 2023
aefa927
test(openapi-generator): replace ava with node:test
ericcrosson-bitgo May 27, 2023
8994082
test(express-wrapper): replace ava with node:test
ericcrosson-bitgo May 27, 2023
40d3123
refactor(typed-express-router): replace ava with node:test
ericcrosson-bitgo May 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Copy link
Contributor Author

@ericcrosson-bitgo ericcrosson-bitgo May 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note this diff, where we necessarily stop running unit tests on Node.js 14 and 16. I personally am all right with this change, but would love to hear what you think!

Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,15 @@ jobs:

strategy:
matrix:
node-version: [lts/-2, lts/-1, lts/*]
node-version:
# Skip lts/-2 while it refers to Node.js 14, since this version
# does not come with Node.js's built-in test runner.
# - lts/-2
# Skip lts/-1 while it refers to Node.js 16, since this version
# ships with a segfault when collecting code coverage with
# Node.js's built-in test runner.
# - lts/-1
- lts/*

name: Node.js ${{ matrix.node-version }}
steps:
Expand All @@ -27,11 +35,6 @@ jobs:
cache: npm
node-version: ${{ matrix.node-version }}

# Install npm greater-than-or-equal-to 7 so we can use npm workspaces.
# We can remove this when Node.js 16 is the oldest LTS
- name: Update npm
run: npm install --global 'npm@>7'

- name: Install dependencies
run: npm ci

Expand Down
6 changes: 3 additions & 3 deletions flake.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading