fix(express-wrapper): dont override status code in req #501
Conversation
In the event of an error in handleRequest, only set the status code on the request if it hasn't already been set. Overriding the status code in the event of an error results in incorrect reporting of the error status code using plugins such as prom-bundle to generate metrics.
jonball4
force-pushed
the
dont-override-statuscode
branch
from
ea840e2 to
363e6a6
Compare
|
🎉 This PR is included in version @api-ts/express-wrapper@1.0.20 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @api-ts/openapi-generator@2.0.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @api-ts/typed-express-router@1.1.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @api-ts/superagent-wrapper@1.1.12 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @api-ts/io-ts-http@2.4.1-beta.1 🎉 The release is available on Your semantic-release bot 📦🚀 |
2 participants
In the event of an error in handleRequest,
only set the status code on the request if it hasn't already been set.
Overriding the status code in the event of an error results in incorrect reporting of the error status code using plugins such as prom-bundle to generate metrics.