Skip to content

Conversation

@bitgopatmcl
Copy link
Contributor

This is technically a breaking change, but on the other hand this was the original intended behavior.

Ticket: BG-46917

@bitgopatmcl bitgopatmcl requested a review from a team April 26, 2022 14:25
@bitgopatmcl
Copy link
Contributor Author

Fixes #53

@jonball4
Copy link
Contributor

@bitgopatmcl why not change the path format in superagent-wrapper instead? Unless...is this path format also used elsewhere?

@bitgopatmcl
Copy link
Contributor Author

It's somewhat arbitrary because the format specified by io-ts-http isn't meant to be tied to express. It could use that format, but would just need to be treated as coincidental.

@jonball4
Copy link
Contributor

It's somewhat arbitrary because the format specified by io-ts-http isn't meant to be tied to express. It could use that format, but would just need to be treated as coincidental.

That makes sense, thanks.

@ericcrosson-bitgo ericcrosson-bitgo merged commit 4d21e38 into BitGo:beta Apr 26, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-beta.5 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.2.0-beta.5 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.2.0-beta.1 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.2.0-beta.5 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants