Skip to content

Conversation

@bitgopatmcl
Copy link
Contributor

Allows overriding codecs defined inside the package itself, rather than just external ones. Because openapi-generator currently does not handle multiple symbols exported with the same name in different files, this just allows any codec in any file in the project to be overridden at the . path like so:

const INTERNAL_CODEC_OVERRIDE: KnownImports = {
  '.': {
    bar: () => E.right({ type: 'primitive', value: 'string' }),
  },
};

However I'm wondering if it would be worth it do implement the path resolution work necessary to enable overriding imports from individual files in case it is needed in the future.

@bitgopatmcl bitgopatmcl marked this pull request as ready for review September 6, 2023 19:56
@bitgopatmcl bitgopatmcl requested a review from a team as a code owner September 6, 2023 19:56
@andrew-scott-fischer andrew-scott-fischer merged commit 42f2d18 into BitGo:master Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

🎉 This PR is included in version @api-ts/openapi-generator@2.7.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version @api-ts/typed-express-router@1.1.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version @api-ts/express-wrapper@1.0.21 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version @api-ts/superagent-wrapper@1.1.12 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

🎉 This PR is included in version @api-ts/io-ts-http@2.4.1-beta.1 🎉

The release is available on @api-ts/io-ts-http

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants