Skip to content

Conversation

@bitgopatmcl
Copy link
Contributor

Adds t.any, t.unknown, and t.UnknownRecord

@bitgopatmcl bitgopatmcl requested a review from a team as a code owner December 11, 2023 15:55
@andrew-scott-fischer andrew-scott-fischer merged commit e469cdd into BitGo:master Dec 11, 2023
@bitgopatmcl bitgopatmcl deleted the add-more-io-ts-definitions branch December 11, 2023 17:57
@github-actions
Copy link

🎉 This PR is included in version @api-ts/openapi-generator@3.0.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

boolean: () => E.right({ type: 'boolean' }),
null: () => E.right({ type: 'null' }),
undefined: () => E.right({ type: 'undefined' }),
unknown: () => E.right({ type: 'any' }),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cries in type-strictness 😭

Am I understanding correctly that the unknown in the LHS refers to TypeScript's unknown type, while the any on the RHS corresponds to OpenAPI's type?

If so, then I guess that's not as egregious as if both were TypeScript types!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the RHS is what eventually gets turned into an OpenAPI schema.

@github-actions
Copy link

🎉 This PR is included in version @api-ts/typed-express-router@1.1.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version @api-ts/express-wrapper@1.0.23 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants