Skip to content

Conversation

@ericcrosson-bitgo
Copy link
Contributor

Since our docstrings and our README.md files ship with the code,
we should publish a new version when these docs are updated.

This change will at least satisfy those requirements, and also possible
ship some new patch version for other docs that aren't visible in
the published artifact, but that sounds okay to me.

You can see on the commit-analyzer readme that the default preset
is angular1 (so no changes there, just making this explicit), and
explicit rules are additve to the base presets2.

Footnotes

  1. https://github.com/semantic-release/commit-analyzer#configuration

  2. https://github.com/semantic-release/commit-analyzer#releaserules

Since our docstrings and our README.md files ship with the code,
we should publish a new version when these docs are updated.

This change will at least satisfy those requirements, and also possible
ship some new patch version for other docs that aren't visible in
the published artifact, but that sounds okay to me.

You can see on the commit-analyzer readme that the default `preset`
is `angular`[^1] (so no changes there, just making this explicit), and
explicit rules are additve to the base presets[^2].

[^1]: https://github.com/semantic-release/commit-analyzer#configuration
[^2]: https://github.com/semantic-release/commit-analyzer#releaserules
@ericcrosson-bitgo ericcrosson-bitgo requested a review from a team May 12, 2022 23:38
@bitgopatmcl bitgopatmcl merged commit b610ec9 into BitGo:beta May 13, 2022
@ericcrosson-bitgo ericcrosson-bitgo deleted the release-patch-versions-on-docs-changes branch May 13, 2022 14:40
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-beta.8 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.2.0-beta.6 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

🎉 This PR is included in version 0.2.0-beta.2 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.2.0-beta.6 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants