Skip to content

Conversation

@bitgopatmcl
Copy link
Contributor

@bitgopatmcl bitgopatmcl commented May 13, 2024

There is a bug with the jsdoc comment parsing when the comment contains a tag with no summary or description:

/**
 * @tag
 */

Without this change, the @tag gets ignored.

@bitgopatmcl bitgopatmcl marked this pull request as ready for review May 13, 2024 14:16
@bitgopatmcl bitgopatmcl requested a review from a team as a code owner May 13, 2024 14:16
@ghost ghost merged commit 1edac54 into master May 13, 2024
@ghost ghost deleted the fix-standalone-tags branch May 13, 2024 14:41
@github-actions
Copy link

🎉 This PR is included in version @api-ts/openapi-generator@3.6.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

tags['example'] = JSON.parse(tags['example']);
} catch (e) {
writingExample = true;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: This ad-hoc parsing is starting to get extremely hairy! Thank goodness for our test suite.

I wonder if an approach using something structured, like parser combinators, might offer any benefits?

@github-actions
Copy link

github-actions bot commented Jun 4, 2024

🎉 This PR is included in version @api-ts/express-wrapper@1.0.26 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jun 4, 2024

🎉 This PR is included in version @api-ts/superagent-wrapper@1.2.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jun 4, 2024

🎉 This PR is included in version @api-ts/typed-express-router@1.1.6 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Aug 5, 2024

🎉 This PR is included in version @api-ts/io-ts-http@3.1.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants