Skip to content

Conversation

@ericcrosson-bitgo
Copy link
Contributor

We currently list monocle-ts and newtype-ts as explicit dependencies,
since these two packages are peer dependencies of io-ts-types1
and npm 6 doesn't automatically install peer dependencies (like npm
7 does).

This commit removes the explicit peer dependencies, because when npm 7+
is used the behavior will be the same. Additionally, in npm 6 these
to packages won't be installed but they aren't needed, so there will
be no breaking change.

Footnotes

  1. https://github.com/gcanti/io-ts-types/blob/master/package.json#L40-L41

We currently list monocle-ts and newtype-ts as explicit dependencies,
since these two packages are peer dependencies of io-ts-types[^1]
and npm 6 doesn't automatically install peer dependencies (like npm
7 does).

This commit removes the explicit peer dependencies, because when npm 7+
is used the behavior will be the same. Additionally, in npm 6 these
to packages won't be installed but they aren't needed, so there will
be no breaking change.

[^1]: https://github.com/gcanti/io-ts-types/blob/master/package.json#L40-L41
Copy link
Contributor

@bitgopatmcl bitgopatmcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bitgopatmcl bitgopatmcl merged commit 67c9267 into BitGo:beta May 20, 2022
@ericcrosson-bitgo ericcrosson-bitgo deleted the remove-explicit-peer-dependencies branch May 20, 2022 00:30
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-beta.10 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.2.0-beta.6 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

🎉 This PR is included in version 0.2.0-beta.2 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.2.0-beta.6 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants