Skip to content

Conversation

@bitgopatmcl
Copy link
Contributor

Adds support for parsing basic template strings in packages/openapi-generator.

  • Add template string parsing function

    • Add parseTemplateLiteral function to handle template strings in packages/openapi-generator/src/codec.ts.
    • Update parsePlainInitializer to call parseTemplateLiteral when encountering a template literal.
  • Add tests for template string parsing

    • Add test cases for basic and compound template literals in packages/openapi-generator/test/codec.test.ts.

@bitgopatmcl bitgopatmcl requested a review from a team as a code owner November 6, 2024 16:55
@bitgopatmcl bitgopatmcl marked this pull request as draft November 6, 2024 16:58
@bitgopatmcl
Copy link
Contributor Author

Marked as draft due to commit message format. I opened #945 to try and get conventional commit messages

@bitgopatmcl bitgopatmcl force-pushed the bitgopatmcl/template-string-parsing branch 2 times, most recently from 9a7c4f6 to 6593f85 Compare November 7, 2024 13:58
Adds support for parsing basic template strings in `packages/openapi-generator`.

* **Add template string parsing function**
  - Add `parseTemplateLiteral` function to handle template strings in `packages/openapi-generator/src/codec.ts`.
  - Update `parsePlainInitializer` to call `parseTemplateLiteral` when encountering a template literal.

* **Add tests for template string parsing**
  - Add test cases for basic and compound template literals in `packages/openapi-generator/test/codec.test.ts`.
@bitgopatmcl bitgopatmcl force-pushed the bitgopatmcl/template-string-parsing branch from 6593f85 to 982e60c Compare November 7, 2024 14:01
@bitgopatmcl bitgopatmcl marked this pull request as ready for review November 7, 2024 14:03
@ericcrosson-bitgo ericcrosson-bitgo merged commit 8c9dd57 into master Nov 11, 2024
6 checks passed
@ericcrosson-bitgo ericcrosson-bitgo deleted the bitgopatmcl/template-string-parsing branch November 11, 2024 14:32
@github-actions
Copy link

🎉 This PR is included in version @api-ts/openapi-generator@5.3.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version @api-ts/typed-express-router@1.1.13 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version @api-ts/express-wrapper@1.0.33 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version @api-ts/superagent-wrapper@1.3.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants