Skip to content

fix(zcash): correct seed_fingerprint formula in proto comments #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BitHighlander merged 1 commit into from
Apr 29, 2026
Merged

fix(zcash): correct seed_fingerprint formula in proto comments #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions messages-zcash.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ message ZcashSignPCZT {
// Phase 3: transparent shielding support
optional uint32 n_transparent_inputs = 30; // 0 for shielded-only (default), >0 for hybrid shielding tx
// Seed identity binding (ZIP-32 §6.1)
optional bytes expected_seed_fingerprint = 31; // 32-byte BLAKE2b-256("Zcash_HD_Seed_FP", seed).
optional bytes expected_seed_fingerprint = 31; // 32-byte ZIP-32 §6.1 seed fingerprint:
// BLAKE2b-256("Zcash_HD_Seed_FP",
// I2LEBSP_8(len(seed)) || seed)
// If present, device verifies match against its own
// seed fingerprint and rejects with Failure on mismatch.
}
Expand Down Expand Up @@ -120,7 +122,9 @@ message ZcashOrchardFVK {
optional bytes ak = 1; // 32-byte authorizing key (Pallas point)
optional bytes nk = 2; // 32-byte nullifier deriving key
optional bytes rivk = 3; // 32-byte commitment randomness key
optional bytes seed_fingerprint = 4; // 32-byte BLAKE2b-256("Zcash_HD_Seed_FP", seed) — ZIP-32 §6.1
optional bytes seed_fingerprint = 4; // 32-byte ZIP-32 §6.1 seed fingerprint:
// BLAKE2b-256("Zcash_HD_Seed_FP",
// I2LEBSP_8(len(seed)) || seed)
// Stable identity of the device's seed; lets a host pin an FVK
// to a specific seed across sessions.
}
Expand Down