Conversation
- Add robust error handling for non-JSON API responses - Handle special response formats like server-sent events and HTML - Improve response formatting in route handlers with pretty-printing - Add fallback to return raw text when JSON parsing fails - Update generated API client and routes with improved error handling
elilambnz
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
scripts/generate-api.jsfile to standardize code style, improve error handling, and enhance functionality for API client generation. The most significant changes include replacing double quotes with single quotes, improving JSON parsing for API responses, and enhancing the Zod schema generation for better type safety.Code Style Standardization:
Error Handling Improvements:
makeApiRequestfunction to handle non-JSON responses gracefully by checking for special prefixes (e.g.,data:,debug:) and falling back to raw text when JSON parsing fails.Functional Enhancements:
Output File Generation: