Potential fix for code scanning alert no. 12: Server-side request forgery#717
Merged
Conversation
Fix code scanning alert for externally-controlled format string
…gery Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/BitSleuthAI/Analyzer/security/code-scanning/12
General fix approach: ensure user-influenced path input is canonicalized and validated after URL parsing, not just pre-checked by regex on raw input. This prevents encoded traversal or normalization edge cases and guarantees the final fetched path matches strict allow-list expectations.
Best fix in this file: in
fetchJson(around lines 55–70), parse URL first, then validateurl.pathname(canonical pathname) against the host allow-list, and reject pathnames containing dot-segments (./..) as an extra guard. Keep existing functionality otherwise (same host allow-list, same query handling, same fetch behavior).Needed changes:
src/lib/blockchain-api.ts, reorder validation so it checksurl.pathnamerather than rawpathname.Suggested fixes powered by Copilot Autofix. Review carefully before merging.