Update Node.js requirement and refactor middleware setup#810
Merged
Conversation
- Pin engines.node to "22.x" instead of open-ended ">=20.19.0" so the production Node major no longer auto-upgrades on new releases - Remove redundant custom Cache-Control header on /_next/static/(.*); Next.js already sets immutable caching for its own build output - Rename middleware file convention to proxy (Next.js 16): src/middleware.ts -> src/proxy.ts and export function middleware -> proxy Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H9xT1uB6VdMvgiG8mByk38
Contributor
Author
|
@claude can you code review the pr 810 and make any changes required |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H9xT1uB6VdMvgiG8mByk38
Contributor
Author
Code review — looks good ✅I reviewed the full diff. The PR cleanly addresses all 4 Vercel build warnings, and the changes are correct and minimal:
Change made during reviewThe renamed Verification
No further changes required from my side. CI was still running when I last checked — I'll keep watching and flag anything that fails. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes three key changes to improve project configuration and code organization:
engines.nodefrom>=20.19.0to22.xto standardize on Node.js 22/_next/static/(.*)header rule fromnext.config.tsthat was setting immutable cache headers, allowing Next.js to handle static asset caching automaticallymiddlewarefunction toproxyinsrc/proxy.tsto better reflect its purpose as a proxy handler rather than Next.js middlewareType of Change
Test Plan
npm run typecheckpasses with the renamed functionnpm run lintpassesChecklist
npm run typecheckpassesnpm run lintpassesnpm run testpasseshttps://claude.ai/code/session_01H9xT1uB6VdMvgiG8mByk38