Skip to content

Remove Node.js 22.x engine constraint and unused jszip types#812

Merged
jamespepper81 merged 1 commit into
devfrom
claude/npm-warnings-node-version-t4p9pa
Jun 28, 2026
Merged

Remove Node.js 22.x engine constraint and unused jszip types#812
jamespepper81 merged 1 commit into
devfrom
claude/npm-warnings-node-version-t4p9pa

Conversation

@jamespepper81

Copy link
Copy Markdown
Contributor

Summary

Removes the Node.js 22.x engine constraint from package.json and the unused @types/jszip dependency. This allows the project to run on any Node.js version, improving flexibility for different development and deployment environments.

Type of Change

  • Bug fix
  • Refactor / cleanup
  • New feature
  • Breaking change
  • Documentation update

Changes

  • Removed engines field specifying Node.js 22.x requirement
  • Removed unused @types/jszip dependency from devDependencies

Test Plan

No testing needed. These are configuration-only changes that remove constraints and unused dependencies. The application functionality remains unchanged.

Checklist

  • npm run typecheck passes
  • npm run lint passes
  • No breaking changes to application code

https://claude.ai/code/session_013HbRTvCwyQpr5onatZ44Sz

Remove the engines.node "22.x" pin from package.json so Vercel uses the
Node version from Project Settings and auto-updates to the latest, clearing
the build warning and restoring build-cache reuse.

Remove the redundant @types/jszip dependency; jszip ships its own type
definitions, so the deprecated stub package is no longer needed.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013HbRTvCwyQpr5onatZ44Sz
@jamespepper81

Copy link
Copy Markdown
Contributor Author

@claude can you code review the pr 812 and make any changes required

Copy link
Copy Markdown
Contributor Author

Code review — PR #812

Reviewed the diff (1 commit, 18-line deletion in package.json + package-lock.json). No changes required.

What the PR does

  • Removes the engines.node: "22.x" pin so Vercel uses the Node version from Project Settings and auto-updates to the latest — clears the repeated "Node.js Version … will not apply" build warning and restores build-cache reuse.
  • Removes the deprecated @types/jszip stub dependency; jszip ships its own types (used in src/lib/tax-export.ts), so it was redundant.

Verification

  • package-lock.json is consistent: @types/jszip removed from root deps and its package node (0 remaining references); root engines block removed.
  • npm run typecheck ✓ — tax-export.ts still typed via jszip's bundled definitions.
  • npm run build ✓ — production build succeeds.

Findings: none (no correctness, reuse, simplification, efficiency, or convention issues).

Note — intentionally left as-is: two install-time npm warn deprecated messages remain (node-domexception, glob). Both are deep transitive deps from upstream SDKs/tooling; overriding them risks breaking runtime AI features (node-domexception is in the OpenAI/Genkit path) or local dev tooling (glob via genkit-cli). Happy to add a low-risk "glob": "^11.0.0" override if you want that one silenced too.


Generated by Claude Code

@jamespepper81 jamespepper81 merged commit c3d311d into dev Jun 28, 2026
5 checks passed
@jamespepper81 jamespepper81 deleted the claude/npm-warnings-node-version-t4p9pa branch June 28, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants