Enhances the wallet setup experience with a strong focus on security, accessibility, and developer ergonomics#549
Merged
Merged
Conversation
Co-authored-by: jamespepper81 <84083764+jamespepper81@users.noreply.github.com>
Co-authored-by: jamespepper81 <84083764+jamespepper81@users.noreply.github.com>
Co-authored-by: jamespepper81 <84083764+jamespepper81@users.noreply.github.com>
Co-authored-by: jamespepper81 <84083764+jamespepper81@users.noreply.github.com>
Co-authored-by: jamespepper81 <84083764+jamespepper81@users.noreply.github.com>
…sx-file Code quality: Fix security and accessibility issues in wallet-setup.tsx
…ce console.log guards Co-authored-by: jamespepper81 <84083764+jamespepper81@users.noreply.github.com>
…able Co-authored-by: jamespepper81 <84083764+jamespepper81@users.noreply.github.com>
…nimatedpressable Enhance AnimatedPressable: accessibility, performance, production safety
Removed hitSlop prop due to TypeScript error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the wallet setup experience with a strong focus on security, accessibility, and developer ergonomics. The most significant changes include improved handling of test/fallback mnemonics, automatic clipboard clearing for sensitive data, expanded accessibility support, and developer-friendly debug logging. The
AnimatedPressablecomponent is also updated with richer accessibility props and improved documentation.Wallet Setup Security & UX Improvements:
FALLBACK_MNEMONIC_12,FALLBACK_MNEMONIC_24) and warnings to users when a test mnemonic is used, ensuring users are aware not to use these for real funds. [1] [2]Accessibility Enhancements:
accessibilityRole,accessibilityLabel,accessibilityHint, andaccessibilityStateto interactive elements (buttons, checkboxes, links) throughout the wallet setup screen for improved screen reader and keyboard navigation support. [1] [2] [3] [4] [5] [6]AnimatedPressable Component Improvements:
AnimatedPressableto support accessibility props (accessibilityLabel,accessibilityRole,accessibilityHint),testID, andhitSlop, and added comprehensive JSDoc comments and usage example for better developer experience and testability. [1] [2] [3] [4]These changes collectively make the wallet setup process safer for users, more accessible, and easier to maintain and debug for developers.