Skip to content

Contains minor improvements and code clean-up across several files. #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamespepper81 merged 2 commits into from
Feb 23, 2026
Merged

Contains minor improvements and code clean-up across several files. #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cea1ab5
fix: resolve build errors by installing deps and fixing lint warnings
claude Feb 23, 2026
0057922
Merge pull request #559 from BitSleuthAI/claude/fix-build-errors-dQf9I
jamespepper81 Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/(tabs)/receive.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ function ReceiveScreenContent({ walletContext }: { walletContext: ReturnType<typ
setIsLoadingAddress(false);
});
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [currentWallet?.xpub, currentWallet?.addresses?.length]);
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ESLint directive is missing an explanatory comment. According to the codebase convention (see app/(tabs)/send.tsx:253-254 and app/passkeys-security.tsx:38-39), when adding eslint-disable-next-line react-hooks/exhaustive-deps, you should include a comment explaining why dependencies are intentionally omitted. For example, you could add a comment like "// walletService is intentionally omitted as it's stable" on the dependency array line.

Suggested change
}, [currentWallet?.xpub, currentWallet?.addresses?.length]);
}, [currentWallet?.xpub, currentWallet?.addresses?.length]); // walletService and stable setters/callbacks are intentionally omitted to avoid unnecessary refetch loops

Copilot uses AI. Check for mistakes.

// Spin animation for the refresh icon
Expand Down
2 changes: 1 addition & 1 deletion app/wallet-setup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ try {
};

// Verify all required functions are available
const requiredFunctions: Array<keyof WalletService> = ['generateMnemonic', 'validateMnemonic', 'createWallet', 'importWallet'];
const requiredFunctions: (keyof WalletService)[] = ['generateMnemonic', 'validateMnemonic', 'createWallet', 'importWallet'];
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces inconsistency with the existing codebase. The file utils/wallet-service-loader.ts:61 uses Array for the same pattern. For consistency, this should remain as Array rather than changing to (keyof WalletService)[]. While both syntaxes are valid TypeScript, consistency across the codebase is important for maintainability.

Suggested change
const requiredFunctions: (keyof WalletService)[] = ['generateMnemonic', 'validateMnemonic', 'createWallet', 'importWallet'];
const requiredFunctions: Array<keyof WalletService> = ['generateMnemonic', 'validateMnemonic', 'createWallet', 'importWallet'];

Copilot uses AI. Check for mistakes.
const missingFunctions = requiredFunctions.filter(func => typeof walletService[func] !== 'function');

if (missingFunctions.length > 0) {
Expand Down
3 changes: 1 addition & 2 deletions components/AnimatedNumber.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
import React, { useEffect } from 'react';
import { StyleProp, TextStyle } from 'react-native';
import { StyleProp, TextInput, TextStyle } from 'react-native';
import Animated, {
useAnimatedStyle,
useSharedValue,
withSpring,
withTiming,
useAnimatedProps,
} from 'react-native-reanimated';
import { TextInput } from 'react-native';

const AnimatedTextInput = Animated.createAnimatedComponent(TextInput);

Expand Down
Loading