Skip to content

minor update to the AnimatedNumber component to ensure that a defaultValue property is included in the animated props#564

Merged
jamespepper81 merged 9 commits into
mainfrom
dev
Feb 23, 2026
Merged

minor update to the AnimatedNumber component to ensure that a defaultValue property is included in the animated props#564
jamespepper81 merged 9 commits into
mainfrom
dev

Conversation

@jamespepper81
Copy link
Copy Markdown
Contributor

This pull request makes a minor update to the AnimatedNumber component to ensure that a defaultValue property is included in the animated props, likely to improve rendering consistency or compatibility.

  • Added defaultValue to the returned object in the useAnimatedProps hook within AnimatedNumber.tsx.

Copilot AI and others added 4 commits February 23, 2026 18:58
Co-authored-by: jamespepper81 <84083764+jamespepper81@users.noreply.github.com>
…s (Reanimated v4)

Co-authored-by: jamespepper81 <84083764+jamespepper81@users.noreply.github.com>
…cies

Fix Reanimated v4 useAnimatedProps type error in AnimatedNumber
Copilot AI review requested due to automatic review settings February 23, 2026 19:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request attempts to add a defaultValue property to the animated props returned by useAnimatedProps in the AnimatedNumber component. However, the change raises concerns about the correctness of mixing controlled and uncontrolled component patterns in react-native-reanimated. The PR also includes extensive package-lock.json reorganization that appears unrelated to the stated purpose.

Changes:

  • Modified AnimatedNumber.tsx to include defaultValue alongside text in useAnimatedProps return value
  • Extensive reorganization of "peer": true markers in package-lock.json (appears to be from running npm install)

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
components/AnimatedNumber.tsx Added defaultValue: text to the object returned by useAnimatedProps, which may conflict with the animated text property
package-lock.json Extensive reorganization of peer dependency markers throughout the file, unrelated to the AnimatedNumber change

Comment thread components/AnimatedNumber.tsx Outdated
jamespepper81 and others added 5 commits February 23, 2026 19:46
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…in AnimatedNumber

Co-authored-by: jamespepper81 <84083764+jamespepper81@users.noreply.github.com>
Fix TypeScript build error in AnimatedNumber: Reanimated 4.x virtual `text` prop
@jamespepper81 jamespepper81 merged commit 9b76546 into main Feb 23, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants