Skip to content
This repository was archived by the owner on Jun 9, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ language: php
php:
- 5.5
- 5.6
- 7.0
- hhvm

before_script:
Expand Down
18 changes: 17 additions & 1 deletion src/BitWeb/ErrorReporting/Service/ErrorService.php
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ public function getErrorReportMetaData()
$meta = new ErrorMeta();
$meta->setIp(Ip::getClientIp());
$meta->setUserAgent((isset($_SERVER['HTTP_USER_AGENT'])) ? $_SERVER['HTTP_USER_AGENT'] : null);
$meta->setUrl(((isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on') ? 'https://' : 'http://') . $_SERVER['SERVER_NAME'] . $_SERVER['REQUEST_URI']);
$meta->setUrl($this->getUrl());
$meta->setPostData($_POST);
$meta->setGetData($_GET);
$meta->setSessionData(isset($_SESSION) ? $_SESSION : null);
Expand Down Expand Up @@ -245,4 +245,20 @@ protected function composeAndSendErrorMail()

$this->eventManager->trigger($this->event, null, $params);
}

/**
* @return string
*/
public function getUrl()
{
if (array_key_exists('HTTP_X_FORWARDED_FOR', $_SERVER)) {
$prefix = (array_key_exists('HTTP_X_FORWARDED_PROTO', $_SERVER) && $_SERVER['HTTP_X_FORWARDED_PROTO'] === 'https') ? 'https://' : 'http://';
$domain = $_SERVER['HTTP_X_FORWARDED_FOR'];
} else {
$prefix = (array_key_exists('HTTPS', $_SERVER) && $_SERVER['HTTPS'] === 'on') ? 'https://' : 'http://';
$domain = $_SERVER['SERVER_NAME'];
}

return $prefix . $domain . $_SERVER['REQUEST_URI'];
}
}
39 changes: 39 additions & 0 deletions test/BitWebTest/ErrorReporting/Service/ErrorServiceTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -181,4 +181,43 @@ public function testRestoreDefaultErrorHandling()
$service = new ErrorService($this->configuration);
$this->assertTrue($service->restoreDefaultErrorHandling());
}

public function testGetUrlWithHttps()
{
$_SERVER['HTTPS'] = 'on';
$_SERVER['SERVER_NAME'] = 'bitweb.ee';
$_SERVER['REQUEST_URI'] = '/error-reporting';

$service = new ErrorService($this->configuration);
$this->assertEquals('https://bitweb.ee/error-reporting', $service->getUrl());
}

public function testGetUrlWithHttpsNotOn()
{
$_SERVER['HTTPS'] = 'off';
$_SERVER['SERVER_NAME'] = 'bitweb.ee';
$_SERVER['REQUEST_URI'] = '/error-reporting';

$service = new ErrorService($this->configuration);
$this->assertEquals('http://bitweb.ee/error-reporting', $service->getUrl());
}

public function testGetUrlWithHttp()
{
$_SERVER['SERVER_NAME'] = 'bitweb.ee';
$_SERVER['REQUEST_URI'] = '/error-reporting';

$service = new ErrorService($this->configuration);
$this->assertEquals('http://bitweb.ee/error-reporting', $service->getUrl());
}

public function testGetUrlWithXForwardedFor()
{
$_SERVER['HTTP_X_FORWARDED_FOR'] = 'bitweb.ee';
$_SERVER['SERVER_NAME'] = 'localhost';
$_SERVER['REQUEST_URI'] = '/error-reporting';

$service = new ErrorService($this->configuration);
$this->assertEquals('http://bitweb.ee/error-reporting', $service->getUrl());
}
}