Conversation
Implements all DTOs and enums needed for the Montonio payment order API: - Shared enums: Currency, Locale, PaymentMethodType, CardPaymentMethod, WalletProvider - Order models: PaymentStatus, Address, LineItem, Payment, PaymentMethodOptions - Request DTO: CreateOrderRequest with builder and fail-fast validation - Response DTOs: CreateOrderResponse, OrderResponse, PaymentIntent (immutable) Field definitions cross-referenced from the official PHP SDK, JS SDK, and community TypeScript client. Uses @JsonCreator for Jackson 3 deserialization (Lombok @Jacksonized incompatible with Jackson 3). Closes #14 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughAdds payment order enums, immutable request/response DTOs and models with Jackson constructors and validation, a design document, a Jakarta Nullable dependency, many unit tests for serialization/validation, and a CODEOWNERS entry. Changes
Sequence Diagram(s)(Skipped — changes are model, DTO and tests; no new multi-component control flow introduced.) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (4)
src/test/java/ee/bitweb/montonio/sdk/order/response/CreateOrderResponseTest.java (1)
43-55: Strengthen the unknown-fields test by assertingpaymentUrltoo.This test currently verifies only
uuid; addingpaymentUrlmakes the mapping guarantee complete.Suggested test tightening
`@Test` void deserializesWithUnknownFieldsIgnored() throws Exception { String json = """ { "uuid": "550e8400-e29b-41d4-a716-446655440000", "paymentUrl": "https://example.com/pay", "extraField": "ignored" } """; CreateOrderResponse response = mapper.readValue(json, CreateOrderResponse.class); assertEquals("550e8400-e29b-41d4-a716-446655440000", response.getUuid()); + assertEquals("https://example.com/pay", response.getPaymentUrl()); }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/test/java/ee/bitweb/montonio/sdk/order/response/CreateOrderResponseTest.java` around lines 43 - 55, In the deserializesWithUnknownFieldsIgnored test in CreateOrderResponseTest, after mapping JSON via mapper.readValue into CreateOrderResponse, add an assertion that response.getPaymentUrl() equals "https://example.com/pay" (in addition to the existing uuid assertion) so the test verifies both mapped fields and ensures unknown fields are ignored.src/main/java/ee/bitweb/montonio/sdk/order/response/PaymentIntent.java (1)
24-25: Defensively copypaymentMethodMetadatato preserve DTO immutability.Line 47 stores the incoming
Mapreference directly, so callers can mutatePaymentIntentafter construction.♻️ Proposed fix
import lombok.Getter; +import java.util.Collections; +import java.util.LinkedHashMap; import java.util.Map; @@ public PaymentIntent( String uuid, PaymentMethodType paymentMethodType, String amount, Currency currency, PaymentStatus status, String serviceFee, Currency serviceFeeCurrency, String createdAt, - Map<String, String> paymentMethodMetadata + `@Nullable` Map<String, String> paymentMethodMetadata ) { @@ - this.paymentMethodMetadata = paymentMethodMetadata; + this.paymentMethodMetadata = paymentMethodMetadata == null + ? null + : Collections.unmodifiableMap(new LinkedHashMap<>(paymentMethodMetadata)); } }Also applies to: 37-48
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/main/java/ee/bitweb/montonio/sdk/order/response/PaymentIntent.java` around lines 24 - 25, The PaymentIntent DTO stores the incoming Map directly in the private final field paymentMethodMetadata, allowing external mutation; update the constructor(s) that accept a Map to defensively copy it (e.g., new HashMap<>(incomingMap) or Collections.unmodifiableMap(new HashMap<>(incomingMap))) and likewise return a defensive copy or unmodifiable view from any accessor (e.g., getPaymentMethodMetadata()) so the PaymentIntent class remains immutable; apply the same defensive-copy pattern to any other Map/Collection fields in PaymentIntent.src/test/java/ee/bitweb/montonio/sdk/order/request/CreateOrderRequestTest.java (1)
126-156: Add blank-value tests for URL fields
CreateOrderRequestvalidates bothreturnUrlandnotificationUrlas non-null and non-blank, but this test class currently only checks null cases. Adding blank-string tests here will lock in the full fail-fast contract.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/test/java/ee/bitweb/montonio/sdk/order/request/CreateOrderRequestTest.java` around lines 126 - 156, Add two tests to CreateOrderRequestTest that mirror the null checks but pass blank strings: implement buildWithBlankReturnUrlThrows which calls CreateOrderRequest.builder() with returnUrl("") and other required fields (merchantReference, notificationUrl, grandTotal, currency, payment(validPayment())) and asserts a MontonioValidationException with getField() == "returnUrl"; and implement buildWithBlankNotificationUrlThrows which sets notificationUrl("") (and provides returnUrl and other required fields) and asserts getField() == "notificationUrl". Ensure test names match and reuse validPayment() like the existing tests.src/main/java/ee/bitweb/montonio/sdk/order/request/CreateOrderRequest.java (1)
37-38: Defensively copylineItemsto preserve value-object semantics
lineItemsis currently stored by reference, so callers can mutate request contents after build time. Consider copying it on assignment.Suggested fix
@@ - this.lineItems = lineItems; + this.lineItems = lineItems == null ? null : List.copyOf(lineItems);Also applies to: 80-80
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/main/java/ee/bitweb/montonio/sdk/order/request/CreateOrderRequest.java` around lines 37 - 38, The CreateOrderRequest currently stores the incoming List<LineItem> lineItems by reference which allows external mutation; change the constructor/assignment (and any builder method that sets lineItems, e.g., the builder/setter at or around the code referenced) to defensively copy the collection (e.g., new ArrayList<>(lineItems)) and store an unmodifiable wrapper (Collections.unmodifiableList(...)) or null if input is null; likewise ensure any getter for lineItems returns the unmodifiable list (or a copy) so callers cannot mutate the internal state.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/plans/2026-04-10-payment-order-models-design.md`:
- Around line 26-31: The fenced code block showing package layout (lines with
"ee.bitweb.montonio.sdk.model/", "ee.bitweb.montonio.sdk.order.model/",
"ee.bitweb.montonio.sdk.order.request/",
"ee.bitweb.montonio.sdk.order.response/") is missing a language tag and triggers
markdownlint MD040; update the opening fence to include a language identifier
(e.g., replace "```" with "```text" or another appropriate language) so the
block is properly annotated while keeping the same content and alignment.
In `@src/main/java/ee/bitweb/montonio/sdk/order/model/Payment.java`:
- Around line 41-43: The current validation in Payment (the null check for
amount) must also enforce that amount > 0; update the validation in the Payment
constructor (and any setAmount / builder method if present) to throw
MontonioValidationException("amount", "must be greater than zero") when
amount.compareTo(BigDecimal.ZERO) <= 0 (after the null check), ensuring zero and
negative values are rejected.
In `@src/main/java/ee/bitweb/montonio/sdk/order/response/OrderResponse.java`:
- Around line 29-30: OrderResponse is not deeply immutable because the List
fields paymentIntents and lineItems are stored and returned by reference; fix by
defensively copying and wrapping them as unmodifiable/immutable collections in
the constructor (e.g., List.copyOf or Collections.unmodifiableList) and return
unmodifiable lists from any getters (getPaymentIntents, getLineItems); apply the
same defensive-copy pattern to the other list fields referenced later in the
class to prevent external mutation.
---
Nitpick comments:
In `@src/main/java/ee/bitweb/montonio/sdk/order/request/CreateOrderRequest.java`:
- Around line 37-38: The CreateOrderRequest currently stores the incoming
List<LineItem> lineItems by reference which allows external mutation; change the
constructor/assignment (and any builder method that sets lineItems, e.g., the
builder/setter at or around the code referenced) to defensively copy the
collection (e.g., new ArrayList<>(lineItems)) and store an unmodifiable wrapper
(Collections.unmodifiableList(...)) or null if input is null; likewise ensure
any getter for lineItems returns the unmodifiable list (or a copy) so callers
cannot mutate the internal state.
In `@src/main/java/ee/bitweb/montonio/sdk/order/response/PaymentIntent.java`:
- Around line 24-25: The PaymentIntent DTO stores the incoming Map directly in
the private final field paymentMethodMetadata, allowing external mutation;
update the constructor(s) that accept a Map to defensively copy it (e.g., new
HashMap<>(incomingMap) or Collections.unmodifiableMap(new
HashMap<>(incomingMap))) and likewise return a defensive copy or unmodifiable
view from any accessor (e.g., getPaymentMethodMetadata()) so the PaymentIntent
class remains immutable; apply the same defensive-copy pattern to any other
Map/Collection fields in PaymentIntent.
In
`@src/test/java/ee/bitweb/montonio/sdk/order/request/CreateOrderRequestTest.java`:
- Around line 126-156: Add two tests to CreateOrderRequestTest that mirror the
null checks but pass blank strings: implement buildWithBlankReturnUrlThrows
which calls CreateOrderRequest.builder() with returnUrl("") and other required
fields (merchantReference, notificationUrl, grandTotal, currency,
payment(validPayment())) and asserts a MontonioValidationException with
getField() == "returnUrl"; and implement buildWithBlankNotificationUrlThrows
which sets notificationUrl("") (and provides returnUrl and other required
fields) and asserts getField() == "notificationUrl". Ensure test names match and
reuse validPayment() like the existing tests.
In
`@src/test/java/ee/bitweb/montonio/sdk/order/response/CreateOrderResponseTest.java`:
- Around line 43-55: In the deserializesWithUnknownFieldsIgnored test in
CreateOrderResponseTest, after mapping JSON via mapper.readValue into
CreateOrderResponse, add an assertion that response.getPaymentUrl() equals
"https://example.com/pay" (in addition to the existing uuid assertion) so the
test verifies both mapped fields and ensures unknown fields are ignored.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e3800521-9a77-4597-8252-2287cb553e6c
📒 Files selected for processing (30)
build.gradledocs/plans/2026-04-10-payment-order-models-design.mdsrc/main/java/ee/bitweb/montonio/sdk/model/CardPaymentMethod.javasrc/main/java/ee/bitweb/montonio/sdk/model/Currency.javasrc/main/java/ee/bitweb/montonio/sdk/model/Locale.javasrc/main/java/ee/bitweb/montonio/sdk/model/PaymentMethodType.javasrc/main/java/ee/bitweb/montonio/sdk/model/WalletProvider.javasrc/main/java/ee/bitweb/montonio/sdk/order/model/Address.javasrc/main/java/ee/bitweb/montonio/sdk/order/model/LineItem.javasrc/main/java/ee/bitweb/montonio/sdk/order/model/Payment.javasrc/main/java/ee/bitweb/montonio/sdk/order/model/PaymentMethodOptions.javasrc/main/java/ee/bitweb/montonio/sdk/order/model/PaymentStatus.javasrc/main/java/ee/bitweb/montonio/sdk/order/request/CreateOrderRequest.javasrc/main/java/ee/bitweb/montonio/sdk/order/response/CreateOrderResponse.javasrc/main/java/ee/bitweb/montonio/sdk/order/response/OrderResponse.javasrc/main/java/ee/bitweb/montonio/sdk/order/response/PaymentIntent.javasrc/test/java/ee/bitweb/montonio/sdk/model/CardPaymentMethodTest.javasrc/test/java/ee/bitweb/montonio/sdk/model/CurrencyTest.javasrc/test/java/ee/bitweb/montonio/sdk/model/LocaleTest.javasrc/test/java/ee/bitweb/montonio/sdk/model/PaymentMethodTypeTest.javasrc/test/java/ee/bitweb/montonio/sdk/model/WalletProviderTest.javasrc/test/java/ee/bitweb/montonio/sdk/order/model/AddressTest.javasrc/test/java/ee/bitweb/montonio/sdk/order/model/LineItemTest.javasrc/test/java/ee/bitweb/montonio/sdk/order/model/PaymentMethodOptionsTest.javasrc/test/java/ee/bitweb/montonio/sdk/order/model/PaymentStatusTest.javasrc/test/java/ee/bitweb/montonio/sdk/order/model/PaymentTest.javasrc/test/java/ee/bitweb/montonio/sdk/order/request/CreateOrderRequestTest.javasrc/test/java/ee/bitweb/montonio/sdk/order/response/CreateOrderResponseTest.javasrc/test/java/ee/bitweb/montonio/sdk/order/response/OrderResponseTest.javasrc/test/java/ee/bitweb/montonio/sdk/order/response/PaymentIntentTest.java
- Validate Payment.amount > 0, not just non-null - Defensive copy for list fields in OrderResponse and CreateOrderRequest - Defensive copy for map field in PaymentIntent - Add language tag to design doc code fence - Add blank-URL validation tests for CreateOrderRequest - Strengthen CreateOrderResponse unknown-fields test - Add zero/negative amount validation tests for Payment Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
docs/plans/2026-04-10-payment-order-models-design.md (1)
82-83: Tighten the deferred-refund wording for clarity.Consider linking the specific follow-up issue directly to make this sentence clearer and easier to track.
Proposed edit
-`isRefundableType`. Refund-related fields are mostly omitted (only `isRefundableType` -is included) pending a future refund models issue. Jackson ignores unknown fields. +`isRefundableType`. Refund-related fields are mostly omitted (only `isRefundableType` +is included) pending follow-up issue `#30` for refund models. Jackson ignores unknown fields.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/plans/2026-04-10-payment-order-models-design.md` around lines 82 - 83, The sentence about deferred refund fields is vague; update the wording around `isRefundableType` to be explicit and add a link/reference to the follow-up refund models issue (e.g., an issue number or URL) so readers can track it; mention that refund-related fields are intentionally omitted for now and that Jackson will ignore unknown fields, and replace "pending a future refund models issue" with the specific issue reference in the `isRefundableType` paragraph.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/main/java/ee/bitweb/montonio/sdk/order/request/CreateOrderRequest.java`:
- Around line 62-64: The constructor validation in CreateOrderRequest currently
only checks for null on grandTotal; update the validation in the
CreateOrderRequest constructor (the grandTotal null-check block) to also reject
non-positive values by throwing MontonioValidationException for grandTotal when
grandTotal.compareTo(BigDecimal.ZERO) <= 0 (use a message like "must be greater
than 0") so zero and negative totals fail fast.
In `@src/main/java/ee/bitweb/montonio/sdk/order/response/OrderResponse.java`:
- Around line 29-30: Mark the nullable list fields and their constructor
parameters and accessors explicitly as `@Nullable`: update the OrderResponse class
to annotate the fields paymentIntents and lineItems, the corresponding
constructor parameters (the ones assigning those fields) and their getters with
the project's nullable annotation (e.g., javax.annotation.Nullable or
org.jetbrains.annotations.Nullable) so static analysis and callers know these
lists can be null; repeat the same change for the other nullable list fields
referenced around lines 55-56.
---
Nitpick comments:
In `@docs/plans/2026-04-10-payment-order-models-design.md`:
- Around line 82-83: The sentence about deferred refund fields is vague; update
the wording around `isRefundableType` to be explicit and add a link/reference to
the follow-up refund models issue (e.g., an issue number or URL) so readers can
track it; mention that refund-related fields are intentionally omitted for now
and that Jackson will ignore unknown fields, and replace "pending a future
refund models issue" with the specific issue reference in the `isRefundableType`
paragraph.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9603b529-dd8e-4a75-b488-fe1cd8964c27
📒 Files selected for processing (8)
docs/plans/2026-04-10-payment-order-models-design.mdsrc/main/java/ee/bitweb/montonio/sdk/order/model/Payment.javasrc/main/java/ee/bitweb/montonio/sdk/order/request/CreateOrderRequest.javasrc/main/java/ee/bitweb/montonio/sdk/order/response/OrderResponse.javasrc/main/java/ee/bitweb/montonio/sdk/order/response/PaymentIntent.javasrc/test/java/ee/bitweb/montonio/sdk/order/model/PaymentTest.javasrc/test/java/ee/bitweb/montonio/sdk/order/request/CreateOrderRequestTest.javasrc/test/java/ee/bitweb/montonio/sdk/order/response/CreateOrderResponseTest.java
✅ Files skipped from review due to trivial changes (2)
- src/main/java/ee/bitweb/montonio/sdk/order/response/PaymentIntent.java
- src/test/java/ee/bitweb/montonio/sdk/order/request/CreateOrderRequestTest.java
🚧 Files skipped from review as they are similar to previous changes (2)
- src/test/java/ee/bitweb/montonio/sdk/order/response/CreateOrderResponseTest.java
- src/test/java/ee/bitweb/montonio/sdk/order/model/PaymentTest.java
- Validate CreateOrderRequest.grandTotal > 0, not just non-null - Add @nullable to list fields in OrderResponse (paymentIntents, lineItems) - Reference issue #30 in design doc for deferred refund models - Add zero/negative grandTotal validation tests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/test/java/ee/bitweb/montonio/sdk/order/request/CreateOrderRequestTest.java (1)
93-272: Consider parameterising repeated required-field validation tests.The null/blank/invalid required-field tests are currently repetitive; a parameterised approach would keep the suite easier to extend and maintain.
♻️ Refactor sketch (JUnit 5 parameterised test)
+import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.Arguments; +import org.junit.jupiter.params.provider.MethodSource; +import java.util.function.Consumer; +import java.util.stream.Stream; @@ + private static Stream<Arguments> invalidRequiredFieldCases() { + return Stream.of( + Arguments.of("merchantReference", (Consumer<CreateOrderRequest.CreateOrderRequestBuilder>) b -> b.merchantReference(null)), + Arguments.of("merchantReference", (Consumer<CreateOrderRequest.CreateOrderRequestBuilder>) b -> b.merchantReference(" ")), + Arguments.of("returnUrl", (Consumer<CreateOrderRequest.CreateOrderRequestBuilder>) b -> b.returnUrl(null)), + Arguments.of("returnUrl", (Consumer<CreateOrderRequest.CreateOrderRequestBuilder>) b -> b.returnUrl(" ")), + Arguments.of("notificationUrl", (Consumer<CreateOrderRequest.CreateOrderRequestBuilder>) b -> b.notificationUrl(null)), + Arguments.of("notificationUrl", (Consumer<CreateOrderRequest.CreateOrderRequestBuilder>) b -> b.notificationUrl(" ")), + Arguments.of("grandTotal", (Consumer<CreateOrderRequest.CreateOrderRequestBuilder>) b -> b.grandTotal(null)), + Arguments.of("grandTotal", (Consumer<CreateOrderRequest.CreateOrderRequestBuilder>) b -> b.grandTotal(BigDecimal.ZERO)), + Arguments.of("grandTotal", (Consumer<CreateOrderRequest.CreateOrderRequestBuilder>) b -> b.grandTotal(new BigDecimal("-1"))), + Arguments.of("currency", (Consumer<CreateOrderRequest.CreateOrderRequestBuilder>) b -> b.currency(null)), + Arguments.of("payment", (Consumer<CreateOrderRequest.CreateOrderRequestBuilder>) b -> b.payment(null)) + ); + } + + `@ParameterizedTest` + `@MethodSource`("invalidRequiredFieldCases") + void buildWithInvalidRequiredFieldsThrows(String expectedField, + Consumer<CreateOrderRequest.CreateOrderRequestBuilder> mutator) { + CreateOrderRequest.CreateOrderRequestBuilder builder = CreateOrderRequest.builder() + .merchantReference("order-123") + .returnUrl("https://example.com/return") + .notificationUrl("https://example.com/notify") + .grandTotal(BigDecimal.TEN) + .currency(Currency.EUR) + .payment(validPayment()); + + mutator.accept(builder); + + MontonioValidationException exception = + assertThrows(MontonioValidationException.class, builder::build); + assertEquals(expectedField, exception.getField()); + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/test/java/ee/bitweb/montonio/sdk/order/request/CreateOrderRequestTest.java` around lines 93 - 272, The tests in CreateOrderRequestTest repeat the same required-field validation pattern; refactor by replacing the multiple buildWithXThrows methods with parameterised tests that drive field name, builder mutations, and expected invalid values: create a `@ParameterizedTest` (e.g., testInvalidRequiredFields) with a static Stream<Arguments> provider that yields tuples of (String expectedField, UnaryOperator<CreateOrderRequest.Builder> invalidator) and in the test call invalidator.apply(CreateOrderRequest.builder()...commonValidValues...) .build() inside assertThrows(MontonioValidationException.class) and assertEquals(expectedField, exception.getField()); keep the existing helper validPayment() and reference CreateOrderRequest.builder(), MontonioValidationException, and getField() to locate code. Ensure providers cover null/blank/zero/negative cases originally tested.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@src/test/java/ee/bitweb/montonio/sdk/order/request/CreateOrderRequestTest.java`:
- Around line 93-272: The tests in CreateOrderRequestTest repeat the same
required-field validation pattern; refactor by replacing the multiple
buildWithXThrows methods with parameterised tests that drive field name, builder
mutations, and expected invalid values: create a `@ParameterizedTest` (e.g.,
testInvalidRequiredFields) with a static Stream<Arguments> provider that yields
tuples of (String expectedField, UnaryOperator<CreateOrderRequest.Builder>
invalidator) and in the test call
invalidator.apply(CreateOrderRequest.builder()...commonValidValues...) .build()
inside assertThrows(MontonioValidationException.class) and
assertEquals(expectedField, exception.getField()); keep the existing helper
validPayment() and reference CreateOrderRequest.builder(),
MontonioValidationException, and getField() to locate code. Ensure providers
cover null/blank/zero/negative cases originally tested.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 89b5eb77-89f3-4cfa-972c-d1453f7e11f8
📒 Files selected for processing (4)
docs/plans/2026-04-10-payment-order-models-design.mdsrc/main/java/ee/bitweb/montonio/sdk/order/request/CreateOrderRequest.javasrc/main/java/ee/bitweb/montonio/sdk/order/response/OrderResponse.javasrc/test/java/ee/bitweb/montonio/sdk/order/request/CreateOrderRequestTest.java
✅ Files skipped from review due to trivial changes (1)
- src/main/java/ee/bitweb/montonio/sdk/order/response/OrderResponse.java
🚧 Files skipped from review as they are similar to previous changes (1)
- src/main/java/ee/bitweb/montonio/sdk/order/request/CreateOrderRequest.java
Member
Author
|
Re: the nitpick about parameterizing the I'd prefer to keep the individual test methods for now. They follow the same pattern used in
The parameterized approach trades readability for conciseness, which isn't a great tradeoff when we only have ~12 cases and the pattern is established. All actionable comments from the review have been addressed. The four inline threads are now resolved. |
Both branches added dependencies; kept both: - jakarta.annotation-api (this branch) - java-jwt (from main) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Assigns @BitWeb/montonio-sdk-maintainers as owners for all key areas: core SDK source/tests, Gradle build files, GitHub config, and AI tooling. Partial progress on #6 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currency,Locale,PaymentMethodType,CardPaymentMethod,WalletProvider) insdk.modelPaymentStatus,Address,LineItem,Payment,PaymentMethodOptions) inorder.modelCreateOrderRequestwith Lombok builder and fail-fast validation inorder.requestCreateOrderResponse,OrderResponse,PaymentIntent) inorder.responsejakarta.annotation-apidependency for@NullableField definitions cross-referenced from the official PHP SDK, JS SDK, and community TypeScript client.
Deferred items (new issues)
OrderResponseintegration (refund fields omitted from this PR)@Jacksonizedcompatibility with Jackson 3 (using explicit@JsonCreatoras workaround)Test plan
MontonioValidationException./gradlew buildpasses (163 tests, 0 failures)Closes #14
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation
Tests
Chores