fixed repository content listing (issue #33)#34
fixed repository content listing (issue #33)#34emocharnik wants to merge 5 commits intoBitbucketPHP:masterfrom
Conversation
GrahamCampbell
left a comment
GrahamCampbell
left a comment
There was a problem hiding this comment.
Thanks for the PR. I've left some feedback.
src/Api/Repositories/Users/Src.php
Outdated
| public function create(array $params = []) | ||
| { | ||
| $path = $this->buildSrcPath(); | ||
| $path = $this->buildSrcPath(...$params); |
There was a problem hiding this comment.
Hmm, I don't think this is quite what we want. What are the exact parameters? And how is createWithFiles effected?
There was a problem hiding this comment.
In createWithFiles method doesn't pass any parameters into buildSrcPath method.
Expected behaviour I described in the issue #33
There was a problem hiding this comment.
If you want to list content of specific commit/branch or specific path you have to pass it as query parameter. Here is a request example
https://api.bitbucket.org/2.0/repositories/atlassian/bbql/src/eefd5ef/tests
There was a problem hiding this comment.
sorry, mixed uo the right action method, moved to list
There was a problem hiding this comment.
That's not a query parameter? https://example.com/foo?bar=baz. bar is a query parameter in that example, bound to baz.
|
Oh, I see. You are calling the wrong method. You need to call |
2 participants
No description provided.