Skip to content
This repository was archived by the owner on Feb 13, 2024. It is now read-only.

Correct address.md example and add a link to locktime in transactionBuilder.md#217

Merged
SpendBCH merged 8 commits intoBitcoin-com:stagefrom
kralux:master
Mar 9, 2019
Merged

Correct address.md example and add a link to locktime in transactionBuilder.md#217
SpendBCH merged 8 commits intoBitcoin-com:stagefrom
kralux:master

Conversation

@kralux
Copy link
Copy Markdown
Contributor

@kralux kralux commented Mar 7, 2019

Changed the query address to match the returned content (see legacyAddress and the rest). The address in the query had nothing to do with the returned data.

cgcardona and others added 3 commits March 3, 2019 10:39
Changed the query address to match the returned content (see legacyAddress and the rest). The address in the query had nothing to do with the returned data.
Added a link for locktime to its description on Mastering Bitcoin Cash. It is useful for people who don't know what to do with that argument...
@kralux
Copy link
Copy Markdown
Contributor Author

kralux commented Mar 7, 2019

Also added a link for the locktime to give a description of how to use it since some people may not be familiar with what the actual number represents (even though they may already know the general concept of locktime)

@kralux kralux changed the title Update address.md Correct address.md example and add a link to locktime in transactionBuilder.md Mar 7, 2019
kralux added 2 commits March 6, 2019 22:51
I felt like a bit of information is needed in the doc else it is mandatory to go over all the examples below to start to understand what needs to be done to create a transaction. It is nice to give a head's up up front.
@kralux
Copy link
Copy Markdown
Contributor Author

kralux commented Mar 7, 2019

Added a small paragraph at the top of the TransactionBuilder to explain what it is and how to use it. I felt like a bit of information is needed in the doc else it is mandatory to go over all the examples below to start to understand what needs to be done to create a transaction. It is nice to give a head's up up front.

kralux added 3 commits March 8, 2019 14:29
More doc is needed for HDNode since much of the nomenclature can be hard to digest for first-time blockchain developers (which is the targeted audience).
More doc is needed for HDNode since much of the nomenclature can be hard to digest for first-time blockchain developers (which is the targeted audience).
@SpendBCH
Copy link
Copy Markdown
Contributor

SpendBCH commented Mar 8, 2019

Much more informative

Thank you! @GitCash 512 bits for @kralux

@GitCash
Copy link
Copy Markdown

GitCash commented Mar 8, 2019

Hey kralux, user SpendBCH tipped you 512 bits in Bitcoin Cash ( ~ $0.065 ).

Click here to claim it!

You can also add the "thumbs down" reaction to SpendBCH's comment above to prevent future tips.

@SpicyPete SpicyPete self-requested a review March 8, 2019 23:50
Copy link
Copy Markdown
Contributor

@SpicyPete SpicyPete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the target to stage?

@SpendBCH SpendBCH changed the base branch from master to stage March 9, 2019 01:31
@SpendBCH SpendBCH merged commit b3d1950 into Bitcoin-com:stage Mar 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants