Tweak to the CSS media query for retina screens#1114
Merged
Conversation
Abhijay007 pointed out that the header banner image is looking blurry on his mobile device in [this comment](#1112 (comment)). Reason is that our retina media query is looking for a pixel ratio of 2 for showing higher resolution images. Various Android phones are a little below 2 (like my Samsung Galaxy A5, which is ~1.875). For those phones, the lower res image looks blurry and the higher-res one would be more appropriate. This PR lowers the pixel ratio requirement from 2 to 1.5. This should work out better on average for diverse ratios. Also added in the dppx unit, which is a newer standard.
✅ Deploy Preview for bitcoin-design-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rabbitholiness
pushed a commit
to rabbitholiness/Guide
that referenced
this pull request
Nov 11, 2024
Abhijay007 pointed out that the header banner image is looking blurry on his mobile device in [this comment](BitcoinDesign#1112 (comment)). Reason is that our retina media query is looking for a pixel ratio of 2 for showing higher resolution images. Various Android phones are a little below 2 (like my Samsung Galaxy A5, which is ~1.875). For those phones, the lower res image looks blurry and the higher-res one would be more appropriate. This PR lowers the pixel ratio requirement from 2 to 1.5. This should work out better on average for diverse ratios. Also added in the dppx unit, which is a newer standard.
GBKS
added a commit
that referenced
this pull request
Dec 5, 2024
* Updates from master * Initial commit - Added cosigner onboarding page - Added images * Text updates - Removed icons on the landing page, as they are not really helpful. - Updated the chapters on the landing page to reflect the final structure. - Updated editor's notes - Minor text changes. * Removes unused images * Back link for reader convenience * Delete _includes/bitcoin-tv 2.svg * Delete _includes/nostr 2.svg * Removed duplicated files * Incorporated final round of feedback - Added a short process overview and diagram to the wallet creation page. - Updated the conclusion for clarity - Minor text changes * Update guide/inheritance-wallet/onboarding-cosigners.md Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com> * Update guide/inheritance-wallet/onboarding-cosigners.md Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com> * Update guide/inheritance-wallet/onboarding-cosigners.md Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com> * Update guide/inheritance-wallet/onboarding-cosigners.md Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com> * Update guide/inheritance-wallet/onboarding-cosigners.md Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com> * Update guide/inheritance-wallet/onboarding-cosigners.md Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com> * Update guide/inheritance-wallet/onboarding-cosigners.md Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com> * Incorporating Daniel's feedback * Text tweak * Updated process overview image * Multiple smaller tweaks - Text change - Removed editor's notes from onboarding page * Added header and preview images * fixing preview image * Removed editor's notes * Update guide/inheritance-wallet/onboarding-cosigners.md Co-authored-by: Christoph Ono <chri@sto.ph> * Preview and header image fixes * fixing image paths * image file size optimizations * Initial content * Updated links * Image updates - Added mobile images for backup material distribution diagram * Minor formatting update * Content refactoring - Updated most of the content, based on the current feedback. - Added mobile images * Addressing Daniel's feedback - Revised content structure - Eliminated lots of typos - Minor image tweaks - Worked on clarity of expression * Updated headline structure * Update guide/inheritance-wallet/backup.md Co-authored-by: Christoph Ono <chri@sto.ph> * Update guide/inheritance-wallet/backup.md Co-authored-by: Christoph Ono <chri@sto.ph> * Cleanup & clarifications - Removed unused images - Text updates for clarification * Adds the 2024 American bitcoin survey to the research page (#1105) Small addition to the research page. * Added home page banner theme for HereComesBitcoin (#1112) * ^Cded home page banner theme for HereComesBitcoin Signed-off-by: Abhijay jain <Abhijay007j@gmail.com> * (Fix) : Resized Banner Images Signed-off-by: Abhijay jain <Abhijay007j@gmail.com> * (Refactor): Compressed Banner Images Signed-off-by: Abhijay jain <Abhijay007j@gmail.com> --------- Signed-off-by: Abhijay jain <Abhijay007j@gmail.com> * CSS media query for retina screens tweak (#1114) Abhijay007 pointed out that the header banner image is looking blurry on his mobile device in [this comment](#1112 (comment)). Reason is that our retina media query is looking for a pixel ratio of 2 for showing higher resolution images. Various Android phones are a little below 2 (like my Samsung Galaxy A5, which is ~1.875). For those phones, the lower res image looks blurry and the higher-res one would be more appropriate. This PR lowers the pixel ratio requirement from 2 to 1.5. This should work out better on average for diverse ratios. Also added in the dppx unit, which is a newer standard. * Bump rexml from 3.2.8 to 3.3.6 (#1111) Bumps [rexml](https://github.com/ruby/rexml) from 3.2.8 to 3.3.6. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.2.8...v3.3.6) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Docker and image compression info tweaks (#1115) Two minor maintenance copy tweaks: - Newer version of Docker use "docker compose up" instead of "docker-compose up". This updates the info about local development in the README - The local build does no longer automatically compress images, so I removed that part and added a note about using a compression tool like ImageOpti. * Update community account Nostr relays (#1119) Several of the listed relays are no longer active. I tested all, compared to what Primal and Damus recommend as defaults, and adjusted the list * Bump rexml from 3.3.6 to 3.3.9 (#1123) Bumps [rexml](https://github.com/ruby/rexml) from 3.3.6 to 3.3.9. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.3.6...v3.3.9) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump webrick from 1.8.1 to 1.8.2 (#1124) Bumps [webrick](https://github.com/ruby/webrick) from 1.8.1 to 1.8.2. - [Release notes](https://github.com/ruby/webrick/releases) - [Commits](ruby/webrick@v1.8.1...v1.8.2) --- updated-dependencies: - dependency-name: webrick dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Initial content commit Added file and images * Updated links & navigation order * Minor text changes * Revision - Updated copy - Fixed a logical flaw that around passing around PSBTs. - Added new & updated existing images. * Minor text tweaks * Text tweak * Final updates - Fixed typos - Added separators between sections - Added preview and header images - Deleted unused images * Update guide/inheritance-wallet/making-changes.md Co-authored-by: Christoph Ono <chri@sto.ph> * Update guide/inheritance-wallet/making-changes.md Co-authored-by: Christoph Ono <chri@sto.ph> * Removed conflicting files * Headline structure update --------- Signed-off-by: Abhijay jain <Abhijay007j@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com> Co-authored-by: Christoph Ono <chri@sto.ph> Co-authored-by: Abhijay Jain <abhijay007j@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
GBKS
added a commit
that referenced
this pull request
Dec 13, 2024
* Updates from master * Initial commit - Added cosigner onboarding page - Added images * Text updates - Removed icons on the landing page, as they are not really helpful. - Updated the chapters on the landing page to reflect the final structure. - Updated editor's notes - Minor text changes. * Removes unused images * Back link for reader convenience * Delete _includes/bitcoin-tv 2.svg * Delete _includes/nostr 2.svg * Removed duplicated files * Incorporated final round of feedback - Added a short process overview and diagram to the wallet creation page. - Updated the conclusion for clarity - Minor text changes * Update guide/inheritance-wallet/onboarding-cosigners.md Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com> * Update guide/inheritance-wallet/onboarding-cosigners.md Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com> * Update guide/inheritance-wallet/onboarding-cosigners.md Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com> * Update guide/inheritance-wallet/onboarding-cosigners.md Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com> * Update guide/inheritance-wallet/onboarding-cosigners.md Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com> * Update guide/inheritance-wallet/onboarding-cosigners.md Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com> * Update guide/inheritance-wallet/onboarding-cosigners.md Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com> * Incorporating Daniel's feedback * Text tweak * Updated process overview image * Multiple smaller tweaks - Text change - Removed editor's notes from onboarding page * Added header and preview images * fixing preview image * Removed editor's notes * Update guide/inheritance-wallet/onboarding-cosigners.md Co-authored-by: Christoph Ono <chri@sto.ph> * Preview and header image fixes * fixing image paths * image file size optimizations * Initial content * Updated links * Image updates - Added mobile images for backup material distribution diagram * Minor formatting update * Content refactoring - Updated most of the content, based on the current feedback. - Added mobile images * Addressing Daniel's feedback - Revised content structure - Eliminated lots of typos - Minor image tweaks - Worked on clarity of expression * Updated headline structure * Update guide/inheritance-wallet/backup.md Co-authored-by: Christoph Ono <chri@sto.ph> * Update guide/inheritance-wallet/backup.md Co-authored-by: Christoph Ono <chri@sto.ph> * Cleanup & clarifications - Removed unused images - Text updates for clarification * Adds the 2024 American bitcoin survey to the research page (#1105) Small addition to the research page. * Added home page banner theme for HereComesBitcoin (#1112) * ^Cded home page banner theme for HereComesBitcoin Signed-off-by: Abhijay jain <Abhijay007j@gmail.com> * (Fix) : Resized Banner Images Signed-off-by: Abhijay jain <Abhijay007j@gmail.com> * (Refactor): Compressed Banner Images Signed-off-by: Abhijay jain <Abhijay007j@gmail.com> --------- Signed-off-by: Abhijay jain <Abhijay007j@gmail.com> * CSS media query for retina screens tweak (#1114) Abhijay007 pointed out that the header banner image is looking blurry on his mobile device in [this comment](#1112 (comment)). Reason is that our retina media query is looking for a pixel ratio of 2 for showing higher resolution images. Various Android phones are a little below 2 (like my Samsung Galaxy A5, which is ~1.875). For those phones, the lower res image looks blurry and the higher-res one would be more appropriate. This PR lowers the pixel ratio requirement from 2 to 1.5. This should work out better on average for diverse ratios. Also added in the dppx unit, which is a newer standard. * Bump rexml from 3.2.8 to 3.3.6 (#1111) Bumps [rexml](https://github.com/ruby/rexml) from 3.2.8 to 3.3.6. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.2.8...v3.3.6) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Docker and image compression info tweaks (#1115) Two minor maintenance copy tweaks: - Newer version of Docker use "docker compose up" instead of "docker-compose up". This updates the info about local development in the README - The local build does no longer automatically compress images, so I removed that part and added a note about using a compression tool like ImageOpti. * Update community account Nostr relays (#1119) Several of the listed relays are no longer active. I tested all, compared to what Primal and Damus recommend as defaults, and adjusted the list * Bump rexml from 3.3.6 to 3.3.9 (#1123) Bumps [rexml](https://github.com/ruby/rexml) from 3.3.6 to 3.3.9. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.3.6...v3.3.9) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump webrick from 1.8.1 to 1.8.2 (#1124) Bumps [webrick](https://github.com/ruby/webrick) from 1.8.1 to 1.8.2. - [Release notes](https://github.com/ruby/webrick/releases) - [Commits](ruby/webrick@v1.8.1...v1.8.2) --- updated-dependencies: - dependency-name: webrick dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Initial content commit Added file and images * Updated links & navigation order * Minor text changes * Revision - Updated copy - Fixed a logical flaw that around passing around PSBTs. - Added new & updated existing images. * Minor text tweaks * Text tweak * Final updates - Fixed typos - Added separators between sections - Added preview and header images - Deleted unused images * Update guide/inheritance-wallet/making-changes.md Co-authored-by: Christoph Ono <chri@sto.ph> * Update guide/inheritance-wallet/making-changes.md Co-authored-by: Christoph Ono <chri@sto.ph> * Removed conflicting files * Added page and image folders * Minor changes * Text revision & links * Text tweaks and image cleanup * added images * file tweaks * file tweaks * file tweaks * Optimized image sizes * Added preview & header images * Added header & preview image for wallet backup page * optimized images * Header image update * Update guide/inheritance-wallet/succession.md Co-authored-by: Christoph Ono <chri@sto.ph> * Addressing Christoph's feedabck * Update guide/inheritance-wallet/succession.md Co-authored-by: paperpsych <149538435+paperpsych@users.noreply.github.com> * Addressing Erik's feedback * Addressing Paperpsych's feedback --------- Signed-off-by: Abhijay jain <Abhijay007j@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com> Co-authored-by: Christoph Ono <chri@sto.ph> Co-authored-by: Abhijay Jain <abhijay007j@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: paperpsych <149538435+paperpsych@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abhijay007 pointed out that the header banner image is looking blurry on his mobile device in this comment.
Reason is that our retina media query is looking for a pixel ratio of 2 for showing higher resolution images. Various Android phones are a little below 2 (like my Samsung Galaxy A5, which is ~1.875). For those phones, the lower res image looks blurry and the higher-res one would be more appropriate. This PR lowers the pixel ratio requirement from 2 to 1.5. This should work out better on average for diverse ratios.
Also added in the dppx unit, which is a newer standard.