Add balances to activity screens #876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GBKS
added
Design
✅ Deploy Preview for bitcoin-design-site ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sbddesign
requested changes
Jul 25, 2022
Collaborator
sbddesign
left a comment
sbddesign
left a comment
There was a problem hiding this comment.
The update to the screens looks good. I noticed a lot of lines have been removed from the compress images cache. Is this an error?
_compress_images_cache.yml
Outdated
Comment on lines
1527
to
1642
| assets/images/guide/how-it-works/lightning-services/lightning-services-mobile.jpg: lightning-services-mobile.jpg | ||
| assets/images/guide/how-it-works/lightning-services/lightning-services-mobile@2x.jpg: lightning-services-mobile@2x.jpg | ||
| assets/images/guide/how-it-works/lightning-services/lightning-services-preview.jpg: lightning-services-preview.jpg | ||
| assets/images/guide/how-it-works/lightning-services/lightning-services.jpg: lightning-services.jpg | ||
| assets/images/guide/how-it-works/lightning-services/lightning-services@2x.jpg: lightning-services@2x.jpg | ||
| assets/images/guide/how-it-works/lightning-services/where-is-this-serviced-offered-mobile.png: where-is-this-serviced-offered-mobile.png | ||
| assets/images/guide/how-it-works/lightning-services/where-is-this-serviced-offered-mobile@2x.png: where-is-this-serviced-offered-mobile@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/where-is-this-serviced-offered.png: where-is-this-serviced-offered.png | ||
| assets/images/guide/how-it-works/lightning-services/where-is-this-serviced-offered@2x.png: where-is-this-serviced-offered@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/Collaborative-funding-mobile.png: Collaborative-funding-mobile.png | ||
| assets/images/guide/how-it-works/lightning-services/Collaborative-funding-mobile@2x.png: Collaborative-funding-mobile@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/Collaborative-funding.png: Collaborative-funding.png | ||
| assets/images/guide/how-it-works/lightning-services/Collaborative-funding@2x.png: Collaborative-funding@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/How-is-service-offered-mobile.png: How-is-service-offered-mobile.png | ||
| assets/images/guide/how-it-works/lightning-services/How-is-service-offered-mobile@2x.png: How-is-service-offered-mobile@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/How-is-service-offered.png: How-is-service-offered.png | ||
| assets/images/guide/how-it-works/lightning-services/How-is-service-offered@2x.png: How-is-service-offered@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/Spend-unconfirmed-mobile.png: Spend-unconfirmed-mobile.png | ||
| assets/images/guide/how-it-works/lightning-services/Spend-unconfirmed-mobile@2x.png: Spend-unconfirmed-mobile@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/Spend-unconfirmed.png: Spend-unconfirmed.png | ||
| assets/images/guide/how-it-works/lightning-services/Spend-unconfirmed@2x.png: Spend-unconfirmed@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/On-demand-channel-mobile.png: On-demand-channel-mobile.png | ||
| assets/images/guide/how-it-works/lightning-services/On-demand-channel-mobile@2x.png: On-demand-channel-mobile@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/On-demand-channel.png: On-demand-channel.png | ||
| assets/images/guide/how-it-works/lightning-services/On-demand-channel@2x.png: On-demand-channel@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/Combining-channel-opens-mobile.png: Combining-channel-opens-mobile.png | ||
| assets/images/guide/how-it-works/lightning-services/Combining-channel-opens-mobile@2x.png: Combining-channel-opens-mobile@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/Combining-channel-opens.png: Combining-channel-opens.png | ||
| assets/images/guide/how-it-works/lightning-services/Combining-channel-opens@2x.png: Combining-channel-opens@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/Watchtowers.png: Watchtowers.png | ||
| assets/images/guide/how-it-works/lightning-services/Watchtowers@2x.png: Watchtowers@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/OnChain-funding-mobile.png: OnChain-funding-mobile.png | ||
| assets/images/guide/how-it-works/lightning-services/OnChain-funding-mobile@2x.png: OnChain-funding-mobile@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/OnChain-funding.png: OnChain-funding.png | ||
| assets/images/guide/how-it-works/lightning-services/OnChain-funding@2x.png: OnChain-funding@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/Lightning-address-mobile.png: Lightning-address-mobile.png | ||
| assets/images/guide/how-it-works/lightning-services/Lightning-address-mobile@2x.png: Lightning-address-mobile@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/Lightning-address.png: Lightning-address.png | ||
| assets/images/guide/how-it-works/lightning-services/Lightning-address@2x.png: Lightning-address@2x.png | ||
| assets/images/guide/daily-spending-wallet/activity/expanded-micropayments.png: expanded-micropayments.png | ||
| assets/images/guide/daily-spending-wallet/activity/expanded-micropayments@2x.png: expanded-micropayments@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/Inbound-liquidity-as-a-service-mobile.png: Inbound-liquidity-as-a-service-mobile.png | ||
| assets/images/guide/how-it-works/lightning-services/Inbound-liquidity-as-a-service-mobile@2x.png: Inbound-liquidity-as-a-service-mobile@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/Inbound-liquidity-as-a-service.png: Inbound-liquidity-as-a-service.png | ||
| assets/images/guide/how-it-works/lightning-services/Inbound-liquidity-as-a-service@2x.png: Inbound-liquidity-as-a-service@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/Backups-mobile.png: Backups-mobile.png | ||
| assets/images/guide/how-it-works/lightning-services/Backups-mobile@2x.png: Backups-mobile@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/Backups.png: Backups.png | ||
| assets/images/guide/how-it-works/lightning-services/Backups@2x.png: Backups@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/what-are-lightning-wallet-servers-mobile.png: what-are-lightning-wallet-servers-mobile.png | ||
| assets/images/guide/how-it-works/lightning-services/what-are-lightning-wallet-servers-mobile@2x.png: what-are-lightning-wallet-servers-mobile@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/what-are-lightning-wallet-servers.png: what-are-lightning-wallet-servers.png | ||
| assets/images/guide/how-it-works/lightning-services/what-are-lightning-wallet-servers@2x.png: what-are-lightning-wallet-servers@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/Watchtowers-mobile.png: Watchtowers-mobile.png | ||
| assets/images/guide/how-it-works/lightning-services/Watchtowers-mobile@2x.png: Watchtowers-mobile@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/Submarine-swaps-mobile.png: Submarine-swaps-mobile.png | ||
| assets/images/guide/how-it-works/lightning-services/Submarine-swaps-mobile@2x.png: Submarine-swaps-mobile@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/Submarine-swaps.png: Submarine-swaps.png | ||
| assets/images/guide/how-it-works/lightning-services/Submarine-swaps@2x.png: Submarine-swaps@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/Offline-payment-mobile.png: Offline-payment-mobile.png | ||
| assets/images/guide/how-it-works/lightning-services/Offline-payment-mobile@2x.png: Offline-payment-mobile@2x.png | ||
| assets/images/guide/how-it-works/lightning-services/Offline-payment.png: Offline-payment.png | ||
| assets/images/guide/how-it-works/lightning-services/Offline-payment@2x.png: Offline-payment@2x.png | ||
| assets/images/guide/designing-products/accessibility/annotations-bad.png: annotations-bad.png | ||
| assets/images/guide/designing-products/accessibility/annotations-bad@2x.png: annotations-bad@2x.png | ||
| assets/images/guide/designing-products/accessibility/annotations-bad-isolated.png: annotations-bad-isolated.png | ||
| assets/images/guide/designing-products/accessibility/annotations-bad-isolated@2x.png: annotations-bad-isolated@2x.png | ||
| assets/images/guide/designing-products/accessibility/annotations-good-isolated.png: annotations-good-isolated.png | ||
| assets/images/guide/designing-products/accessibility/annotations-good-isolated@2x.png: annotations-good-isolated@2x.png | ||
| assets/images/guide/designing-products/accessibility/annotations-good.png: annotations-good.png | ||
| assets/images/guide/designing-products/accessibility/annotations-good@2x.png: annotations-good@2x.png | ||
| assets/images/guide/designing-products/accessibility/color-vision-defficiencies.png: color-vision-defficiencies.png | ||
| assets/images/guide/designing-products/accessibility/color-vision-defficiencies@2x.png: color-vision-defficiencies@2x.png | ||
| assets/images/guide/designing-products/accessibility/dynamic-type.png: dynamic-type.png | ||
| assets/images/guide/designing-products/accessibility/dynamic-type@2x.png: dynamic-type@2x.png | ||
| assets/images/guide/designing-products/accessibility/multi-sensory-feedback.png: multi-sensory-feedback.png | ||
| assets/images/guide/designing-products/accessibility/multi-sensory-feedback@2x.png: multi-sensory-feedback@2x.png | ||
| assets/images/guide/designing-products/accessibility/ordering-bad.png: ordering-bad.png | ||
| assets/images/guide/designing-products/accessibility/ordering-bad@2x.png: ordering-bad@2x.png | ||
| assets/images/guide/designing-products/accessibility/ordering-good.png: ordering-good.png | ||
| assets/images/guide/designing-products/accessibility/ordering-good@2x.png: ordering-good@2x.png | ||
| assets/images/guide/designing-products/accessibility/accessibility-preview.jpg: accessibility-preview.jpg | ||
| assets/images/guide/designing-products/accessibility/accessibility-mobile.jpg: accessibility-mobile.jpg | ||
| assets/images/guide/designing-products/accessibility/accessibility-mobile@2x.jpg: accessibility-mobile@2x.jpg | ||
| assets/images/guide/designing-products/accessibility/accessibility.jpg: accessibility.jpg | ||
| assets/images/guide/designing-products/accessibility/accessibility@2x.jpg: accessibility@2x.jpg | ||
| assets/images/guide/designing-products/accessibility/annotations-bad-big.png: annotations-bad-big.png | ||
| assets/images/guide/designing-products/accessibility/annotations-bad-isolated-big.png: annotations-bad-isolated-big.png | ||
| assets/images/guide/designing-products/accessibility/annotations-good-big.png: annotations-good-big.png | ||
| assets/images/guide/designing-products/accessibility/annotations-good-isolated-big.png: annotations-good-isolated-big.png | ||
| assets/images/guide/designing-products/accessibility/ordering-bad-big.png: ordering-bad-big.png | ||
| assets/images/guide/designing-products/accessibility/ordering-good-big.png: ordering-good-big.png | ||
| assets/images/guide/glossary/address/address-compact.png: address-compact.png | ||
| assets/images/guide/glossary/address/address-compact@2x.png: address-compact@2x.png | ||
| assets/images/guide/glossary/address/address-expanded.png: address-expanded.png | ||
| assets/images/guide/glossary/address/address-expanded@2x.png: address-expanded@2x.png | ||
| assets/images/guide/glossary/address/address-invalid.png: address-invalid.png | ||
| assets/images/guide/glossary/address/address-invalid@2x.png: address-invalid@2x.png | ||
| assets/images/guide/glossary/address/address-valid.png: address-valid.png | ||
| assets/images/guide/glossary/address/address-valid@2x.png: address-valid@2x.png | ||
| assets/images/guide/glossary/address/address-reuse.png: address-reuse.png | ||
| assets/images/guide/glossary/address/address-reuse@2x.png: address-reuse@2x.png | ||
| assets/images/guide/resources/design-files/bitcoin-for-local-business-trifold.png: bitcoin-for-local-business-trifold.png | ||
| assets/images/guide/resources/design-files/bitcoin-for-local-business-trifold@2x.png: bitcoin-for-local-business-trifold@2x.png | ||
| assets/images/guide/daily-spending-wallet/sending/confirm-high-fees.png: confirm-high-fees.png | ||
| assets/images/guide/daily-spending-wallet/sending/confirm-high-fees@2x.png: confirm-high-fees@2x.png | ||
| assets/animations/astronaut/images/img_0.png: img_0.png | ||
| assets/animations/astronaut/images/img_1.png: img_1.png | ||
| assets/animations/contribute/formatting/bitcoin-design-seal-miami-edition.png: bitcoin-design-seal-miami-edition.png | ||
| assets/animations/contribute/formatting/bitcoin-design-seal.png: bitcoin-design-seal.png | ||
| assets/animations/contribute/formatting/bitcoin-design-seal-miami-edition@2x.png: bitcoin-design-seal-miami-edition@2x.png | ||
| assets/animations/contribute/formatting/bitcoin-design-seal@2x.png: bitcoin-design-seal@2x.png | ||
| assets/images/home/banner/bits-and-pieces-fallback.png: bits-and-pieces-fallback.png | ||
| assets/images/home/banner/bits-and-pieces-fallback@2x.png: bits-and-pieces-fallback@2x.png | ||
| assets/images/guide/resources/design-files/bitcoin-wallet-backup-print-template.jpg: bitcoin-wallet-backup-print-template.jpg | ||
| assets/images/guide/resources/design-files/bitcoin-wallet-backup-print-template@2x.jpg: bitcoin-wallet-backup-print-template@2x.jpg |
Collaborator
There was a problem hiding this comment.
Why are these being removed from the compress cache?
Bosch-0
previously approved these changes
Jul 29, 2022
Collaborator
Bosch-0
left a comment
Bosch-0
left a comment
There was a problem hiding this comment.
Looks good! I think there is lots of stuff we need to update in the UI kit, once this milestone is wrapped up lets all do a thorough review of it
Bosch-0
approved these changes
Aug 1, 2022
Collaborator
|
Love the design iterations for these! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧌Preview👣
Closes #875