Add designathon promo on the home page #924
Conversation
GBKS
added
Copy
✅ Deploy Preview for bitcoin-design-site ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sbddesign
left a comment
sbddesign
left a comment
There was a problem hiding this comment.
Looks nice! Left a suggestion to make the paragraph perkier with exclamation marks, but don't consider that a blocking change.
Also would be nice:
- if the event was higher above the fold (but this is time sensitive and that would take a little work to make that look right)
- if the image could be a link (but requires venturing out from the traditional jekyll includes we use)
So having said all that, I think we should get it on the site and start promoting it. Can tweak it later.
|
We could add the persistent banner stickied to the top of the page. I know you didn't like this approach Christoph but It looks fine and brings it ATF without having to move too many things around moving too many parts. |
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Using HTML instead of our usual include, because otherwise it won't render the link for some reason.
|
Thanks for the feedback. I just accepted the copy change and updated the image to be a link (using HTML instead of markdown - I think it's OK because this is a temporary short-term thing). For a persistent banner, please also consider that we have a sticky nav bar, and an expanding menu on mobile. If that banner is also sticks and sits above the nav bar, the code for the menu needs to be updated to make that positioning work, and for the expanding menu to account for the height difference. It takes some CSS and JS fiddling to get this right. Why not just take over the top banner altogether? Only downside is that it wouldn't be a direct link, people would have to scroll down a bit to get to that. Not a huge issue though. |
|
Merged this one, as the bolt.fun announcement will happen in the next hour (fingers crossed) and there are some links floating around that lead to our home page, not the event page. |
Without this promo there's no way to discover the event from the website. I put this together fairly quickly for the announcement today, feedback appreciated.
Preview