Skip to content

Conversation

@BitcoinErrorLog
Copy link
Owner

Features Added

Annotation Deletion

  • Users can now delete their own annotations
  • Delete button appears in AnnotationCard (only for annotation owner)
  • Deletes from both local storage and Pubky homeserver
  • Removes highlight from page when deleted
  • Added deleteAnnotationPost method to pubky-api-sdk

Annotation Toggle

  • Toggle switch in popup Quick Actions section
  • Keyboard shortcut Alt+Shift+A (or Option+Shift+A on Mac) to toggle on/off
  • Setting persists across sessions
  • When disabled, annotation button won't appear when selecting text
  • Updated keyboard shortcuts modal with new shortcut

Bug Fixes

  • Fixed annotation button click handler (was being hidden before click completed)
  • Fixed TypeScript build errors (unused variables, duplicate functions, null checks)
  • Fixed offscreen.html script path for Vite build

Testing

  • ✅ Build completes successfully
  • ✅ Delete button only shows for annotation owner
  • ✅ Toggle works from both UI and keyboard shortcut
  • ✅ Setting persists correctly

- Add delete functionality for user-owned annotations
  - Delete button in AnnotationCard (only shown for owner)
  - Delete from local storage and Pubky homeserver
  - Remove highlights from page when deleted
  - Added deleteAnnotationPost method to pubky-api-sdk

- Add annotation toggle feature
  - Toggle switch in popup Quick Actions
  - Keyboard shortcut Alt+Shift+A to toggle on/off
  - Persists setting in storage
  - Prevents annotation button from appearing when disabled
  - Updated keyboard shortcuts modal

- Fix annotation button click handler
  - Changed from onmousedown to onclick with mousedown prevention
  - Prevents button from being hidden before click completes
  - Added check to prevent hiding when clicking button/modal

- Fix TypeScript build errors
  - Fixed unused variable warnings
  - Fixed duplicate function implementations
  - Fixed null check issues
@BitcoinErrorLog BitcoinErrorLog merged commit f08dff0 into main Dec 10, 2025
BitcoinErrorLog added a commit that referenced this pull request Dec 10, 2025
…and-toggle

Add annotation delete and toggle features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants