Skip to content

[Sync] Update project files from source repository (44a1cf8)#291

Merged
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bitcoin-schema-20260307-092154-44a1cf8
Mar 7, 2026
Merged

[Sync] Update project files from source repository (44a1cf8)#291
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bitcoin-schema-20260307-092154-44a1cf8

Conversation

@mrz1836
Copy link
Copy Markdown
Member

@mrz1836 mrz1836 commented Mar 7, 2026

What Changed

  • GitHub Actions security improvements: Moved sensitive tokens from inline usage to environment variables in setup-go-with-cache/action.yml and parse-env/action.yml to prevent token exposure in logs
  • Removed GONOSUMCHECK configuration: Eliminated the conditional setting of GONOSUMCHECK environment variable in the private module authentication step
  • Version updates: Updated MAGE_X_GOLANGCI_LINT_VERSION from v2.10.1 to v2.11.1 in .github/env/10-mage-x.env
  • Added security permissions: Added explicit contents: read permissions to multiple workflow files (codeql-analysis.yml, fortress-security-scans.yml, fortress.yml, scorecard.yml) and pre-commit environment configuration

Why It Was Necessary

  • Prevent accidental token exposure in GitHub Actions logs by storing sensitive values in environment variables rather than inline expressions
  • Follow security best practices by explicitly declaring minimal required permissions for GitHub Actions workflows
  • Keep tooling dependencies up-to-date with the latest golangci-lint version for improved linting capabilities

Testing Performed

  • Verify GitHub Actions workflows successfully authenticate with private Go modules using the refactored token handling
  • Confirm golangci-lint v2.11.1 executes correctly in CI pipelines
  • Validate that explicit permissions do not break existing workflow functionality

Impact / Risk

  • Low Risk: Changes are focused on security hardening and minor version updates without altering core functionality
  • Security Improvement: Reduced risk of token exposure in logs and more restrictive workflow permissions following principle of least privilege
  • Potential Impact: Removal of GONOSUMCHECK configuration may affect projects that previously relied on this environment variable being set automatically

Copilot AI review requested due to automatic review settings March 7, 2026 14:22
@mrz1836 mrz1836 self-assigned this Mar 7, 2026
@mrz1836 mrz1836 added automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps labels Mar 7, 2026
@github-actions github-actions Bot added size/S Small change (11–50 lines) update General updates labels Mar 7, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs GitHub Actions and CI configuration from the source repository, focusing on tightening workflow permissions, reducing token exposure in logs, and updating tool versions used by GoFortress CI.

Changes:

  • Refactored composite actions to pass sensitive values via env: (instead of inline expressions) and removed GONOSUMCHECK auto-configuration.
  • Updated CodeQL action SHAs and bumped golangci-lint versions used by pre-commit and MAGE-X.
  • Adjusted workflow permissions (notably for Gitleaks PR commenting) and updated the govulncheck Go toolchain version.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
.github/workflows/scorecard.yml Bumps CodeQL upload-sarif action pin (but workflow/job permissions need to allow checkout).
.github/workflows/fortress.yml Grants pull-requests: write to the security reusable-workflow call for PR commenting.
.github/workflows/fortress-security-scans.yml Switches Gitleaks to github.token, adjusts permissions; removed passing github-token into Go setup (breaking private module auth).
.github/workflows/codeql-analysis.yml Updates CodeQL init/autobuild/analyze action pins.
.github/env/10-pre-commit.env Bumps pre-commit golangci-lint version.
.github/env/10-mage-x.env Bumps MAGE-X golangci-lint version.
.github/env/00-core.env Bumps GOVULNCHECK Go version.
.github/actions/setup-go-with-cache/action.yml Moves private module token handling into an environment variable; removes GONOSUMCHECK setup.
.github/actions/parse-env/action.yml Moves env-json input into env: to avoid inline expansion.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread .github/workflows/scorecard.yml
Comment thread .github/workflows/fortress-security-scans.yml
Comment thread .github/workflows/fortress-security-scans.yml
Comment thread .github/workflows/fortress-security-scans.yml
@mrz1836 mrz1836 merged commit 0f6c607 into master Mar 7, 2026
53 checks passed
@github-actions github-actions Bot deleted the chore/sync-files-bitcoin-schema-20260307-092154-44a1cf8 branch March 7, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps size/S Small change (11–50 lines) update General updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants