Conversation
There was a problem hiding this comment.
Pull request overview
Syncs GitHub Actions and CI configuration from the source repository, focusing on tightening workflow permissions, reducing token exposure in logs, and updating tool versions used by GoFortress CI.
Changes:
- Refactored composite actions to pass sensitive values via
env:(instead of inline expressions) and removedGONOSUMCHECKauto-configuration. - Updated CodeQL action SHAs and bumped golangci-lint versions used by pre-commit and MAGE-X.
- Adjusted workflow permissions (notably for Gitleaks PR commenting) and updated the govulncheck Go toolchain version.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/scorecard.yml | Bumps CodeQL upload-sarif action pin (but workflow/job permissions need to allow checkout). |
| .github/workflows/fortress.yml | Grants pull-requests: write to the security reusable-workflow call for PR commenting. |
| .github/workflows/fortress-security-scans.yml | Switches Gitleaks to github.token, adjusts permissions; removed passing github-token into Go setup (breaking private module auth). |
| .github/workflows/codeql-analysis.yml | Updates CodeQL init/autobuild/analyze action pins. |
| .github/env/10-pre-commit.env | Bumps pre-commit golangci-lint version. |
| .github/env/10-mage-x.env | Bumps MAGE-X golangci-lint version. |
| .github/env/00-core.env | Bumps GOVULNCHECK Go version. |
| .github/actions/setup-go-with-cache/action.yml | Moves private module token handling into an environment variable; removes GONOSUMCHECK setup. |
| .github/actions/parse-env/action.yml | Moves env-json input into env: to avoid inline expansion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
setup-go-with-cache/action.ymlandparse-env/action.ymlto prevent token exposure in logsGONOSUMCHECKenvironment variable in the private module authentication stepMAGE_X_GOLANGCI_LINT_VERSIONfromv2.10.1tov2.11.1in.github/env/10-mage-x.envcontents: readpermissions to multiple workflow files (codeql-analysis.yml, fortress-security-scans.yml, fortress.yml, scorecard.yml) and pre-commit environment configurationWhy It Was Necessary
Testing Performed
Impact / Risk