Skip to content

[Sync] Update project files from source repository (e729be1)#296

Merged
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bitcoin-schema-20260318-182108-e729be1
Mar 18, 2026
Merged

[Sync] Update project files from source repository (e729be1)#296
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bitcoin-schema-20260318-182108-e729be1

Conversation

@mrz1836
Copy link
Member

@mrz1836 mrz1836 commented Mar 18, 2026

What Changed

  • Updated minimum required Go version for benchstat from 1.23 to 1.25 throughout the setup-benchstat GitHub Action
  • Modified version check logic to compare against Go 1.25 (changed from MINOR -lt 23 to MINOR -lt 25)
  • Updated all documentation strings, comments, and error messages to reflect the new 1.25+ requirement
  • Changed example Go versions in descriptions from "1.24.x, 1.22" to "1.25.x, 1.24"
  • Updated success and warning messages to reference Go 1.25 instead of Go 1.23

Why It Was Necessary

  • Benchstat likely introduced breaking changes or new required features in Go 1.25 that make older versions incompatible
  • Ensures the action fails early with clear messaging when users attempt to run with unsupported Go versions
  • Maintains consistency between version check logic, user-facing documentation, and actual compatibility requirements

Testing Performed

  • Verify the action correctly skips benchstat installation when Go version is below 1.25
  • Test version parsing logic with various Go version formats (1.25, 1.25.x, 1.26.x)
  • Confirm error messages and warnings display the correct minimum version requirement (1.25)

Impact / Risk

  • Breaking Change: Existing workflows using Go 1.23 or 1.24 will now skip benchstat installation instead of proceeding
  • Risk: Medium - users on Go 1.23-1.24 will need to upgrade their Go version to continue using benchstat features
  • Migration: Teams using affected Go versions must update to Go 1.25+ or accept that benchstat will be skipped

@mrz1836 mrz1836 self-assigned this Mar 18, 2026
Copilot AI review requested due to automatic review settings March 18, 2026 22:21
@mrz1836 mrz1836 added automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps labels Mar 18, 2026
@github-actions github-actions bot added size/S Small change (11–50 lines) update General updates labels Mar 18, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GoFortress benchstat setup to require Go 1.25+, aligning the composite action’s version gate and user-facing messaging with the newer benchstat toolchain expectation.

Changes:

  • Raised the minimum Go version check for benchstat installation from 1.23 to 1.25 in the setup-benchstat composite action.
  • Bumped MAGE-X and benchstat tool versions in CI environment configuration.
  • Updated the test-matrix workflow note to reflect the new Go 1.25+ benchstat requirement.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/fortress-test-matrix.yml Updates benchstat setup note to reference Go 1.25+ requirement.
.github/env/10-mage-x.env Bumps MAGE-X version and benchstat pseudo-version used by workflows/actions.
.github/actions/setup-benchstat/action.yml Updates go-version requirement messaging and changes version-check threshold to 1.25+.
Comments suppressed due to low confidence (1)

.github/workflows/fortress-test-matrix.yml:187

  • With the action now skipping benchstat for Go < 1.25, this workflow’s current matrix (GO_PRIMARY_VERSION/GO_SECONDARY_VERSION are set to 1.24.x in .github/env/00-core.env) will always skip benchstat on all runners. If benchmark comparison tests depend on benchstat being present, consider bumping the CI Go version(s) to 1.25+ (or installing benchstat using a separate, compatible toolchain) so benchmarks don’t silently lose comparison coverage.
      # Setup benchstat (required for benchmark comparison tests)
      # Note: benchstat requires Go 1.25+, action will skip for older versions
      # --------------------------------------------------------------------
      - name: 📊 Setup benchstat
        uses: ./.github/actions/setup-benchstat
        with:
          benchstat-version: ${{ env.MAGE_X_BENCHSTAT_VERSION }}
          runner-os: ${{ matrix.os }}
          go-version: ${{ matrix.go-version }}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@mrz1836 mrz1836 merged commit 1c6ebdf into master Mar 18, 2026
50 checks passed
@github-actions github-actions bot deleted the chore/sync-files-bitcoin-schema-20260318-182108-e729be1 branch March 18, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps size/S Small change (11–50 lines) update General updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants