Skip to content

Fix Derive Address Validation#906

Merged
zupzup merged 1 commit into
masterfrom
fix-derive-address-validation
Apr 23, 2026
Merged

Fix Derive Address Validation#906
zupzup merged 1 commit into
masterfrom
fix-derive-address-validation

Conversation

@zupzup
Copy link
Copy Markdown
Collaborator

@zupzup zupzup commented Apr 23, 2026

  • The Address derivation endpoint used it's own alpha node id - but we're asking for a specific alpha
  • Add logging

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes payment address derivation validation by ensuring the beta mint derives the address using the requested alpha node id (rather than implicitly using its own), and adds error logging to aid debugging in the mint “clowder” flow.

Changes:

  • Fetch alpha mint info (get_info) and pass alpha_node_id into DeriveEbillPaymentAddressRequest.
  • Add error logs for failures fetching mint info / betas and for address mismatch diagnostics.
  • Bump bcr-common git revision to a commit that supports the updated request shape/behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/bcr-ebill-api/src/external/mint.rs Uses alpha node_id in derive-address request and improves logging around clowder info, betas, and mismatch cases.
Cargo.toml Updates bcr-common git revision to pick up the corresponding wire/API changes.

@zupzup zupzup force-pushed the fix-derive-address-validation branch from f78c3ef to 7213731 Compare April 23, 2026 10:41
@zupzup zupzup force-pushed the fix-derive-address-validation branch from 7213731 to f828bdd Compare April 23, 2026 10:47
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.58%. Comparing base (691eaf1) to head (f828bdd).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
crates/bcr-ebill-api/src/external/mint.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #906   +/-   ##
=======================================
  Coverage   70.58%   70.58%           
=======================================
  Files         139      139           
  Lines       27704    27708    +4     
=======================================
+ Hits        19554    19557    +3     
- Misses       8150     8151    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zupzup zupzup merged commit 3849863 into master Apr 23, 2026
9 of 10 checks passed
@zupzup zupzup deleted the fix-derive-address-validation branch April 23, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants