Skip to content

Add tabs Withdraw and Deposit to AMM#402

Merged
ihomp merged 5 commits intoBithomp:mainfrom
pandablue0809:feat/add-withdraw-and-deposit-to-amm
Jul 4, 2025
Merged

Add tabs Withdraw and Deposit to AMM#402
ihomp merged 5 commits intoBithomp:mainfrom
pandablue0809:feat/add-withdraw-and-deposit-to-amm

Conversation

@pandablue0809
Copy link
Copy Markdown
Contributor

Issue

#396

@pandablue0809 pandablue0809 requested a review from ihomp June 25, 2025 21:51
@ihomp
Copy link
Copy Markdown
Member

ihomp commented Jun 27, 2025

if we have a half length components, they need to be alligned
Screenshot 2025-06-27 at 18 43 27
Screenshot 2025-06-27 at 18 43 17
Screenshot 2025-06-27 at 18 43 08

@ihomp
Copy link
Copy Markdown
Member

ihomp commented Jun 27, 2025

We need the same checkbox as in the AMM create

@ihomp
Copy link
Copy Markdown
Member

ihomp commented Jun 27, 2025

The order for the tabs and the menu should be:

  • Amm deposit
  • Amm withdrawal
  • Amm vote
  • Amm create

Copy link
Copy Markdown
Member

@ihomp ihomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, but let's improve the UI a bit

@pandablue0809 pandablue0809 requested a review from ihomp June 27, 2025 20:46
@pandablue0809
Copy link
Copy Markdown
Contributor Author

@ihomp
I fixed
plz check again 🙏

@ihomp
Copy link
Copy Markdown
Member

ihomp commented Jul 2, 2025

  • The code looks a bit bloated - as many pieces are repeated for each separate case..

  • it's ok to leave it as it is, for simplicity and in order not to spend too much time for it.

  • I haven't tested it yet.

  • @Anna15170221, can you please test this one locally?

  • make sure that "Trading Fee Vote" is correct.

  • Also suggest if any text updates and additions are needed, or links/explanations.

@Anna15170221
Copy link
Copy Markdown
Contributor

@ihomp I've tested locally. The whole process with switching all modes seems working fine.
I've asked the separate questions in slack.

@ihomp ihomp merged commit 3e6e08d into Bithomp:main Jul 4, 2025
@pandablue0809 pandablue0809 deleted the feat/add-withdraw-and-deposit-to-amm branch July 14, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants