Skip to content

fix logic bug in enableGUI implementation#1218

Merged
PeterSurda merged 1 commit intoBitmessage:v0.6from
f97ada87:opmode-switches-fix1
Apr 16, 2018
Merged

fix logic bug in enableGUI implementation#1218
PeterSurda merged 1 commit intoBitmessage:v0.6from
f97ada87:opmode-switches-fix1

Conversation

@f97ada87
Copy link
Copy Markdown
Contributor

Fixes logic bug in enableGUI switch implementation from PR #1214

@PeterSurda PeterSurda requested review from MahendraNG and g1itch April 13, 2018 11:33
@PeterSurda PeterSurda added the bug Something isn't working as it's supposed to label Apr 13, 2018
@PeterSurda
Copy link
Copy Markdown
Member

thanks

@f97ada87
Copy link
Copy Markdown
Contributor Author

Don't mention it :)

@PeterSurda PeterSurda merged commit 54651c7 into Bitmessage:v0.6 Apr 16, 2018
@f97ada87 f97ada87 deleted the opmode-switches-fix1 branch April 16, 2018 09:31
@PeterSurda
Copy link
Copy Markdown
Member

@omkar1117 well I already merged it but you can create a new PR, since you're new here, please note the contribution guidelines: https://bitmessage.org/wiki/Contribute

@f97ada87
Copy link
Copy Markdown
Contributor Author

@omkar1117 The entire section is a FIXME right now due to the recent introduction of the enableGUI variable. The actual logic is roughly like this:

if enableGUI:
    if state.curses: # non default GUI
        if check_curses:
            gui_curses_and_never_return()
        else:
            complain_no_curses_and_exit()
    else: # default GUI is PyQT
        if check_pyqt:
            gui_pyqt_and_never_return()
        else:
            complain_no_pyqt_and_exit()

# no GUI code past this line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as it's supposed to

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants