Handle missing settingsversion. #1747
Conversation
Otherwise I get this with python 3.8.7 when starting BM: TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType' (assuming changes in #1746)
PeterSurda
left a comment
PeterSurda
left a comment
There was a problem hiding this comment.
Look at the BMConfigDefaults dict inside src/bmconfigparser.py.
| config = BMConfigParser() | ||
| if not config.has_option('bitmessagesettings', 'settingsversion'): | ||
| config.set('bitmessagesettings', 'settingsversion', 1) | ||
| settingsversion = config.getint('bitmessagesettings', 'settingsversion') |
There was a problem hiding this comment.
Better to just add a default value into src/bmconfigparser.py
There was a problem hiding this comment.
Adding it like this at least doesn't help:
"bitmessagesettings": {
"settingsversion": 1,
"maxaddrperstreamsend": 500,
There was a problem hiding this comment.
Try using safeGetInt instead of getint in addition to adding the default value into the dict.
There was a problem hiding this comment.
switching to safegetint makes no difference whether settingsversion is included in BMConfigDefaults or not. No idea what the underlying cause is but my proposed fix adds only two lines...
There was a problem hiding this comment.
settingsversion = config.safeGetInt('bitmessagesettings', 'settingsversion', 1)No default or the default from BMConfigDefaults is a possible bonus of python3 configparser.
Again, please read the tests: https://github.com/Bitmessage/PyBitmessage/blob/v0.6/src/tests/test_config.py#L40
Current PyBitmessage code should pass the tests.
@PeterSurda FIXME: It is also considered to be an exceptional case in current code when you open an existing config and it has no settings version. That's why getint() was retained there I think.
There was a problem hiding this comment.
The code you give is one of the changes I tried with stated effect. To me looks like only error from tests is in Ui_MainWindow which isn't related to this as far as I can see. If you want me to make additional changes you'll have to be more specific than "rest the tests".
3 participants
Otherwise I get this with python 3.8.7 when starting BM: TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType' (assuming changes in #1746)