Added api.py methods testcases by kdcis · Pull Request #1864 · Bitmessage/PyBitmessage

kdcis · 2021-10-15T14:02:13Z

Added statusBar, getAllInboxMessages, getAllInboxMessageIds, getInboxMessageById, getInboxMessagesByReceiver, trashMessage, trashInboxMessage & addSubscription, methods testcases

PeterSurda

Make test strings into variables (maybe class variables)

PeterSurda

make the changes as discussed

PeterSurda

Fix linter issues

g1itch

Another portion of garbage );

g1itch · 2021-11-11T13:43:20Z

 sample_deterministic_addr4 = 'BM-2cWzSnwjJ7yRP3nLEWUV5LisTZyREWSzUK'
+
+sample_statusbar_msg = "new status bar message"
+sample_inbox_msg_receiver_address = 'BM-2cWzSnwjJ7yRP3nLEWUV5LisTZyREWSzUK'


Why double the sample_deterministic_addr4 3 lines above?

PeterSurda · 2021-11-17T07:11:12Z

        """Test two numeric params"""
        return a + b

+    @command('clearUISignalQueue')


something to make this only available in test mode

My preferred way would be to create an additional decorator for testmode functions.

PeterSurda · 2021-11-17T07:11:20Z

        """Update GUI statusbar message"""
        queues.UISignalQueue.put(('updateStatusBar', message))

+    @command('getStatusBar')


also only in test mode

PeterSurda · 2021-11-22T07:06:07Z

        self.aliases = aliases

    def __call__(self, func):
+        if func.__name__ in ["HandleclearUISignalQueue", "HandleGetStatusBar"] \


create a constant, say

TESTMODE_FUNCTIONS = ["HandleclearUISignalQueue", "HandleGetStatusBar"] if func.__name__ in TESTMODE_FUNCTIONS and not state.testmode: return None

PeterSurda

Just a minor change.

PeterSurda · 2021-11-22T07:25:19Z

+            len(json.loads(
+                self.api.getAllInboxMessageIds())["inboxMessageIds"]) == 2
+        )
+        self.assertTrue(


assertEqual

PeterSurda · 2021-11-22T07:25:31Z

+            len(json.loads(
+                self.api.getInboxMessageById(hexlify(sample_inbox_msg_ids[2])))["inboxMessage"]) == 1
+        )
+        self.assertTrue(


assertEqual

…MessageById, getInboxMessagesByReceiver, trashMessage, trashInboxMessage & addSubscription, methods testcases & updated related functions

…r functions, replaced sample_inbox_msg_receiver_address by sample_deterministic_addr4

…& added print for getAllInboxMessages to check build failure

…age parameter

… method

… api.py and separated inbox & trash testcases

PeterSurda · 2021-12-03T07:09:39Z

        self.aliases = aliases

    def __call__(self, func):
+


PeterSurda · 2021-12-03T07:12:44Z

+            len(json.loads(
+                self.api.getAllInboxMessages())["inboxMessages"]),
+            4,
+            json.loads(self.api.getAllInboxMessages())["inboxMessages"]


Maybe add a comment explaining this is the custom error message to aid in debugging.

PeterSurda reviewed Oct 22, 2021

View reviewed changes

Comment thread src/bitmessagemain.py Outdated

PeterSurda reviewed Oct 22, 2021

View reviewed changes

Comment thread src/tests/test_api.py Outdated

PeterSurda reviewed Oct 22, 2021

View reviewed changes

Comment thread src/tests/test_api.py Outdated

PeterSurda reviewed Oct 22, 2021

View reviewed changes

Comment thread src/tests/test_api.py

PeterSurda reviewed Oct 22, 2021

View reviewed changes

Comment thread src/tests/test_api.py Outdated

PeterSurda reviewed Oct 22, 2021

View reviewed changes

Comment thread src/tests/test_api.py Outdated

PeterSurda reviewed Oct 22, 2021

View reviewed changes

Comment thread src/tests/test_api.py

PeterSurda reviewed Oct 22, 2021

View reviewed changes

Comment thread src/tests/test_process.py Outdated

kdcis force-pushed the v0.6-test-api-testcase branch from 443ad5a to a172230 Compare October 22, 2021 08:30

g1itch reviewed Oct 25, 2021

View reviewed changes

Comment thread src/bitmessagemain.py Outdated

kdcis force-pushed the v0.6-test-api-testcase branch from 734207d to 79812fd Compare October 26, 2021 12:37

PeterSurda reviewed Oct 28, 2021

View reviewed changes

Comment thread src/tests/test_api.py Outdated

PeterSurda requested changes Oct 28, 2021

View reviewed changes

kdcis changed the title ~~Added statusBar, getAllInboxMessages & addSubscription methods testcases~~ Added statusBar, getAllInboxMessages, getAllInboxMessageIds, getInboxMessageById, getInboxMessagesByReceiver, trashMessage, trashInboxMessage & addSubscription, methods testcases Oct 28, 2021

kdcis changed the title ~~Added statusBar, getAllInboxMessages, getAllInboxMessageIds, getInboxMessageById, getInboxMessagesByReceiver, trashMessage, trashInboxMessage & addSubscription, methods testcases~~ Added api.py methods testcases Oct 28, 2021

kdcis force-pushed the v0.6-test-api-testcase branch from 18c48a9 to d84cd8a Compare October 28, 2021 14:03

PeterSurda reviewed Oct 29, 2021

View reviewed changes

Comment thread src/api.py Outdated

PeterSurda reviewed Oct 29, 2021

View reviewed changes

Comment thread src/bitmessagemain.py

PeterSurda reviewed Oct 29, 2021

View reviewed changes

Comment thread src/tests/test_api.py Outdated

PeterSurda requested changes Oct 29, 2021

View reviewed changes

kdcis force-pushed the v0.6-test-api-testcase branch from d84cd8a to 754d20b Compare October 29, 2021 07:01

PeterSurda reviewed Nov 1, 2021

View reviewed changes

Comment thread src/testmode_init.py Outdated

PeterSurda requested changes Nov 1, 2021

View reviewed changes

PeterSurda reviewed Nov 1, 2021

View reviewed changes

Comment thread src/tests/test_api.py

g1itch reviewed Nov 1, 2021

View reviewed changes

Comment thread src/tests/test_api.py Outdated

PeterSurda reviewed Nov 2, 2021

View reviewed changes

Comment thread src/tests/test_api.py Outdated

PeterSurda reviewed Nov 2, 2021

View reviewed changes

Comment thread src/testmode_init.py

kdcis force-pushed the v0.6-test-api-testcase branch from dfe8c1e to 4553802 Compare November 2, 2021 07:39

PeterSurda reviewed Nov 3, 2021

View reviewed changes

Comment thread src/tests/test_api.py

PeterSurda reviewed Nov 3, 2021

View reviewed changes

Comment thread src/tests/test_api.py

PeterSurda requested changes Nov 11, 2021

View reviewed changes

Comment thread src/api.py Outdated

kdcis force-pushed the v0.6-test-api-testcase branch from 867d419 to 8bf2c78 Compare November 11, 2021 08:39

g1itch reviewed Nov 11, 2021

View reviewed changes

Comment thread src/api.py Outdated

g1itch reviewed Nov 11, 2021

View reviewed changes

kdcis force-pushed the v0.6-test-api-testcase branch 3 times, most recently from 8d67694 to 53cd1d2 Compare November 15, 2021 16:21

PeterSurda reviewed Nov 16, 2021

View reviewed changes

Comment thread src/tests/test_process.py

kdcis force-pushed the v0.6-test-api-testcase branch from 53cd1d2 to 682f042 Compare November 16, 2021 07:24

PeterSurda reviewed Nov 17, 2021

View reviewed changes

PeterSurda reviewed Nov 22, 2021

View reviewed changes

Comment thread src/tests/samples.py

PeterSurda requested changes Nov 22, 2021

View reviewed changes

PeterSurda reviewed Nov 22, 2021

View reviewed changes

PeterSurda reviewed Nov 30, 2021

View reviewed changes

Comment thread src/tests/test_api.py

kdcis added 7 commits December 2, 2021 19:11

Added statusBar, getAllInboxMessages, getAllInboxMessageIds, getInbox…

9a194f0

…MessageById, getInboxMessagesByReceiver, trashMessage, trashInboxMessage & addSubscription, methods testcases & updated related functions

Added testmode check for HandleclearUISignalQueue & HandleGetStatusBa…

21cb4e5

…r functions, replaced sample_inbox_msg_receiver_address by sample_deterministic_addr4

Created testmode decorator & routed command decorator through it

56ec5b8

Added anouncement addr comment, replaces assertTrue with assertEqual …

62ffe96

…& added print for getAllInboxMessages to check build failure

Instead of print added getAllInboxMessages values in assertEqual mess…

21d5a6c

…age parameter

Merged inbox & trash functions related testcases into single testcase…

1617527

… method

Added undeleteMessage function in helper_inbox & respective method in…

5771f21

… api.py and separated inbox & trash testcases

kdcis force-pushed the v0.6-test-api-testcase branch from b3b5dae to 5771f21 Compare December 2, 2021 13:41

PeterSurda reviewed Dec 3, 2021

View reviewed changes

Comment thread src/api.py

self.aliases = aliases

def __call__(self, func):

Copy link
Copy Markdown

Member

PeterSurda Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why space?

PeterSurda reviewed Dec 3, 2021

View reviewed changes

PeterSurda approved these changes Dec 3, 2021

View reviewed changes

PeterSurda merged commit 5771f21 into Bitmessage:v0.6 Dec 3, 2021

g1itch mentioned this pull request Feb 17, 2022

Fix BMConfigParser.setTemp() broken in a5773999 #1928

Merged

Conversation

kdcis commented Oct 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PeterSurda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PeterSurda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PeterSurda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

g1itch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PeterSurda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kdcis commented Oct 15, 2021 •

edited

Loading