Don't propagate loggers; add some logging.#291
Merged
Atheros1 merged 2 commits intoBitmessage:masterfrom Jul 13, 2013
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
@XJ9: What makes IOError an exception we should catch?
Contributor
There was a problem hiding this comment.
@fiatflux Python throws IOError if there is no old config directory.
Contributor
Author
There was a problem hiding this comment.
Ah, of course. Thanks. Later today I'll add a comment to that effect or switch away from the use of exceptions for this case.
Atheros1
pushed a commit
that referenced
this pull request
Jul 13, 2013
Don't propagate loggers; add some logging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I disabled logger propagation to prevent the root logger from duplicating the custom loggers. In the future there might be something we want to do with the root logger, but I think this is the best way for now to avoid double messages.